summaryrefslogtreecommitdiff
path: root/helm-mode.el
Commit message (Collapse)AuthorAge
* Ensure to use a string as default fname in dialogsThierry Volpiatto2020-09-09
|
* Fix use-dialog predicateThierry Volpiatto2020-09-08
|
* Check use-file-dialog valueThierry Volpiatto2020-09-08
|
* Honor use-file-dialog when opening file from menu (#2381)Thierry Volpiatto2020-09-08
| | | | Call x-file-dialog instead of helm-read-file-name when opening file from menu.
* Make read-buffer-to-switch advice function internalThierry Volpiatto2020-09-05
| | | | and add docstring and comments.
* Fix read-buffer by using minibuffer-completion-tableThierry Volpiatto2020-09-05
| | | | | | | | | | Try to use minibuffer-completion-table if it is bound otherwise fallback to internal-complete-buffer. The problem is that the definition of read-buffer-to-switch is wrong, as it pass minibuffer-completion-table only through minibuffer-setup-hook which is too late for helm and other backends used as read-buffer-function, so advise read-buffer-to-switch from helm-mode.
* Improve previous commit which is not handling current-bufferThierry Volpiatto2020-09-04
| | | | | | | | Use `internal-complete-buffer-except' as default collection, assuming `switch-to-buffer' doesn't need the current buffer and `kill-buffer' add it on top of completion list. This may be wrong in other functions, but lets use this as there is no better solutions to abstract this for now.
* Remove internal buffers from `buffer-list'Thierry Volpiatto2020-09-04
| | | | | We need this in helm-mode because we don't use a transformer like in helm-buffers.
* Fix docstringThierry Volpiatto2020-09-04
|
* Fall back to last-command when not finding the caller in completion-in-regionThierry Volpiatto2020-09-02
|
* Fix issues running emacs built from the native-comp branch (#2375)Graham Clark2020-08-30
| | | | | | | | | | | | | | The emacs native-comp branch provides "a modified Emacs capable of compiling and running Emacs Lisp as native code in form of re-loadable elf files" (https://akrl.sdf.org/gccemacs.html). Functions that are natively-compiled do not return t to byte-code-function-p, but do return t to subr-native-elisp-p, a function that is built-in to the native-comp emacs. The problem here is that helm-symbol-name tries to call symbol-name on an object if it is not functionp OR byte-code-function-p; when running with native-comp, this now needs to include subr-native-elisp-p too. I've also modified some other functions that use a similar pattern.
* Remove space perhaps added by annotation in the right place (#2365, #2360)Thierry Volpiatto2020-08-16
| | | | | | | This avoid error when result is not a string like in CRM. Do this in the right cond clause of helm-completion-in-region--insert-result instead of doing it earlier in helm--completion-in-region.
* Remove space at end of completion at insertion (#2360)Thierry Volpiatto2020-08-13
|
* Pass 'exact or 'finished to :exit-function according to try-completion (#2356)Thierry Volpiatto2020-08-10
|
* New variable to allows completing-read return a listThierry Volpiatto2020-08-07
| | | | | | | | | When non nil `helm-comp-read' will return marked candidates, a list instead of a single candidate, even if no mark it will return a list of one elemnt, the selected candidate. This will break all completing-reads when helm-mode is enabled if set globally, have to be only used in let bindings, this allows external packages to make use of marks in their completing-reads when helm-mode is enabled.
* Exit completion-at-point with 'finished status (#2356)Thierry Volpiatto2020-08-05
| | | | | | | | Allow running extra property :exit-function (Issues #2265, #2356). Passing 'finished to `completion--done' is probably the more logical as completion is always finished in our case when pressing RET, at one point 'finished was addind a space at insertion so we used 'exact, but it seems it is no more the case.
* Fix completion-at-point on special strings (#2355)Thierry Volpiatto2020-08-03
|
* Fix docstring and comments (#2353)Thierry Volpiatto2020-08-01
|
* Ignore separator when it is not a string (#2353)Thierry Volpiatto2020-08-01
|
* New variable to handle default separator for crm (#2353)Thierry Volpiatto2020-07-31
|
* Fix byte compiler warningsNicholas Vollmer2020-07-28
|
* Use :extend attr in all deffaceThierry Volpiatto2020-06-29
|
* Allow invalid candidates in helm-read-file-name (#2331)Thierry Volpiatto2020-06-25
| | | | Add missing block lost when merging cache code.
* Fix predicate in helm-read-file-nameThierry Volpiatto2020-06-22
| | | | helm-find-files-get-candidates is now returning a list of cons cells.
* Fix helm-read-file-name to fit with new HFF codeThierry Volpiatto2020-06-22
|
* Cleanup unneeded commented codeThierry Volpiatto2020-06-22
|
* Make helm-read-file-name working with new HFF cachingThierry Volpiatto2020-06-22
|
* Fix documentationManuel Uberti2020-06-03
|
* Allow passing minibuffer-completion-confirm valueThierry Volpiatto2020-05-28
| | | | | | | | | | | | | | | | | | directly in :must-match without let-binding it. * helm.el (helm-internal): Let-bind minibuffer-completion-confirm on top. (helm--set-minibuffer-completion-confirm): New. (helm-move-selection-common): Use it here. * helm-mode.el (helm-comp-read): No need to cons must-match now it is handled by helm-source. (helm-comp-read): No need now to let-bind minibuffer-completion-confirm. (helm-read-file-name): Same. * helm-source.el (helm--create-source): A slot with a boolean value == t is now aaded as (foo . t) instead of (foo) in alist so that assoc-defaut or (cdr (assq...)) return the real value. (helm-source): Fix must-match docstring.
* Get rid of any-prefixesThierry Volpiatto2020-05-04
|
* Append separator when completing multiple candidatesakater2020-05-03
| | | | | | | | * helm-mode.el (helm-completion-in-region--insert-result): Separator is auto-appended when completing multiple candidates so that user doesn't have to type it in explicitly to trigger completion. It is safe to submit completion results with trailing separator still in minibuffer.
* Fix issue with CRM separator #2298Thierry Volpiatto2020-04-28
| | | | | * helm-mode.el (helm-completion-in-region--insert-result): Use crm-separator as default if available.
* Use instead `equal` instead of `string=` to compare display propertiesIqbal Ansari2020-04-27
| | | | This avoids the error that might occur if the candidates have image set display property
* Avoid error with candidates with an image as display (#2296).Thierry Volpiatto2020-04-26
|
* Use :nomark in completing-read'sThierry Volpiatto2020-02-27
| | | | | * helm-mode.el (helm-completing-read-default-1): Do it. (helm-completing-read-default-2): Do it.
* Fix #2274 completion--done should be called with 'exactThierry Volpiatto2020-01-27
| | | | | | | as argument in our case, with 'finished, an extra space is added at insertion which is wrong. * helm-mode.el (helm--completion-in-region): Do it.
* Rename function and add commentThierry Volpiatto2020-01-26
| | | | | | * helm-mode.el (helm-completion-in-region--selection): Renamed from helm-completion-in-region-selection. (helm--completion-in-region): Add comment.
* Remove hook in the unwind-protect formThierry Volpiatto2020-01-26
| | | | | | to ensure the hook is removed even on quit. * helm-mode.el (helm--completion-in-region): Do it.
* Check string before running completion--doneThierry Volpiatto2020-01-26
| | | | * helm-mode.el (helm--completion-in-region): Do it.
* Don't loose properties in completion-in-region (#2265)Thierry Volpiatto2020-01-22
| | | | | * helm-mode.el (helm-completion-in-region-selection): New. (helm--completion-in-region): Use it in helm-before-action-hook.
* Honor :exit-function in completion-in-region (#2265)Thierry Volpiatto2020-01-21
| | | | * helm-mode.el (helm--completion-in-region): Call completion--done at end.
* Use completion-ignore-caseThierry Volpiatto2020-01-19
| | | | | | | * helm-lib.el (helm-dynamic-completion): Do it. * helm-mode.el (helm-completing-read-default-2): Do it. (helm-flex-add-score-as-prop): Do it. (helm--completion-in-region): Do it.
* Make initial all-completions only in file completionThierry Volpiatto2020-01-15
| | | | | | | This initial call is useful only when completing filenames in shell/eshell-mode so check if completing filenames in style fn. * helm-mode.el (helm-completion--multi-all-completions-1): Do it.
* Fix typo in prvious commitThierry Volpiatto2020-01-05
| | | | | * helm-mode.el (helm-comp-read-get-candidates): predicate vs test.
* Fix error probably introduced when merging branchsThierry Volpiatto2020-01-05
| | | | | | | at some point. Improve as well file completion checking while I am at it. * helm-mode.el (helm-comp-read-get-candidates): Do it.
* Revert "Add shell and eshell to helm-completion-styles-alist (#2261)"Thierry Volpiatto2020-01-04
| | | | This reverts commit 7ba50746bf4bb00848602f8d8cdf473fdb84cda2.
* Add ggtags-find-tag-dwim to CR handlers (#2262)Thierry Volpiatto2020-01-03
| | | | * helm-mode.el (helm-completing-read-handlers-alist): Do it.
* Remove uncalled test in or clause (#2261)Thierry Volpiatto2020-01-03
| | | | | * helm-mode.el (helm-completion--multi-all-completions-1): Do it, add comment as well.
* Fix completion in *shell modes (#2261)Thierry Volpiatto2020-01-03
| | | | | | | | when helm style is alone. Needs bash-completion disabled as well to reproduce bug in shell-mode, eshell is not affected by bash-completion. * helm-mode.el (helm-completion--multi-all-completions-1): Do it.
* Add shell and eshell to helm-completion-styles-alist (#2261)Thierry Volpiatto2020-01-03
| | | | | | | | | | as a workaround waiting a better fix for these modes. Both are working fine with emacs style when helm and one of flex or helm-flex is used along with helm completion style. Also shell-mode is completing correctly when bash-completion package is installed. * helm-mode.el (helm-completion-styles-alist): Add eshell and shell.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-17 16:52:43 +0000