diff options
| author | Moritz Ulrich <moritz@tarn-vedra.de> | 2013-12-28 22:42:38 +0100 |
|---|---|---|
| committer | John Wiegley <johnw@newartisans.com> | 2013-12-28 18:11:25 -0600 |
| commit | 85bc05a673fc790c6c373756067b183bafd51552 (patch) | |
| tree | a653838a48899155337b78de31dd86008a8bb3fb /ledger-commodities.el | |
| parent | 1ea63cb11cfe2c28a6c34a284a7950f403276ab0 (diff) | |
Fix `ledger-string-to-number' for decimal-comma
--=-=-=
Content-Type: text/plain
Hi John,
Small bug, caused by ill-formatted elisp. This is a small patch, so i
think making a fork & opening a Pull Request is a bit too much. I'll go
this route if I make bigger contributions in the future.
From de1fb19ded5300a227d58e3d3094928b211db09b Mon Sep 17 00:00:00 2001
From: Moritz Ulrich <moritz@tarn-vedra.de>
Date: Sat, 28 Dec 2013 22:37:54 +0100
Subject: [PATCH] ledger-string-to-number: Fix nil return value with
decimal-comma.
Unfavorable formatting hid this bug pretty well. In case of true-ish
`decimal-comma' or "decimal-comma' in `ledger-environment-alist', the
ill-formatted `if' (and the whole function) returns nil.
Signed-off-by: Moritz Ulrich <moritz@tarn-vedra.de>
Diffstat (limited to 'ledger-commodities.el')
| -rw-r--r-- | ledger-commodities.el | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/ledger-commodities.el b/ledger-commodities.el index 865305d..aed3f6c 100644 --- a/ledger-commodities.el +++ b/ledger-commodities.el @@ -117,11 +117,11 @@ Returns a list with (value commodity)." (defun ledger-number-to-string (n &optional decimal-comma) (let ((str (number-to-string n))) - (if (or decimal-comma - (assoc "decimal-comma" ledger-environment-alist)) - (while (string-match "\\." str) - (setq str (replace-match "," nil nil str))) - str))) + (when (or decimal-comma + (assoc "decimal-comma" ledger-environment-alist)) + (while (string-match "\\." str) + (setq str (replace-match "," nil nil str)))) + str)) (defun ledger-commodity-to-string (c1) "Return string representing C1. |