summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDominique Dumont <dod@debian.org>2021-06-04 18:47:51 +0200
committerDominique Dumont <dod@debian.org>2021-06-04 18:47:51 +0200
commit06a9f339d4bb62fb6304c570300be9c9f93395c2 (patch)
tree8d7877237b9f30224982ad627177fbc0ef2ba21e
parentd74039596792aca69b8185b1fe3946bbdc401084 (diff)
fixup returns
-rw-r--r--lib/Config/Model/Backend/Dpkg/Copyright.pm1
-rw-r--r--lib/Config/Model/Backend/DpkgStoreRole.pm2
-rw-r--r--lib/Config/Model/Dpkg/Copyright/License.pm5
3 files changed, 7 insertions, 1 deletions
diff --git a/lib/Config/Model/Backend/Dpkg/Copyright.pm b/lib/Config/Model/Backend/Dpkg/Copyright.pm
index 6966bc90..755af369 100644
--- a/lib/Config/Model/Backend/Dpkg/Copyright.pm
+++ b/lib/Config/Model/Backend/Dpkg/Copyright.pm
@@ -302,6 +302,7 @@ sub _store_license_info ($self, $lic_node, $key, $check, $v_ref ) {
sub _store_file_license ($self, $lic_object, $check, $v_ref) {
return unless grep { /\S/ } map {$_->[0]} $v_ref->@*; # skip empty-ish value
+
my ( $lic_line_ref, @lic_text_ref ) = $v_ref->@*;
my $lic_line = $lic_line_ref->[0];
$logger->debug("_store_file_license check $check called on ".$lic_object->name);
diff --git a/lib/Config/Model/Backend/DpkgStoreRole.pm b/lib/Config/Model/Backend/DpkgStoreRole.pm
index c6f70f27..049b55d1 100644
--- a/lib/Config/Model/Backend/DpkgStoreRole.pm
+++ b/lib/Config/Model/Backend/DpkgStoreRole.pm
@@ -42,6 +42,7 @@ sub store_section_list_element ($self, $logger, $list_obj, $check, $v_ref) {
}
}
$list_obj->annotation(@list_comment) if @list_comment;
+ return;
}
sub store_section_leaf_element ($self, $logger, $elt_obj, $check, $v_ref) {
@@ -75,6 +76,7 @@ sub store_section_leaf_element ($self, $logger, $elt_obj, $check, $v_ref) {
$elt_obj->store( value => $v, check => $check );
$elt_obj->annotation(@comment) if @comment ;
$elt_obj->notify_change(note => $note, really => 1) if $note ;
+ return;
}
1;
diff --git a/lib/Config/Model/Dpkg/Copyright/License.pm b/lib/Config/Model/Dpkg/Copyright/License.pm
index 36ea7ae5..a9133c41 100644
--- a/lib/Config/Model/Dpkg/Copyright/License.pm
+++ b/lib/Config/Model/Dpkg/Copyright/License.pm
@@ -19,7 +19,8 @@ sub BUILD ($self, @args) {
$self->SUPER::BUILD(@args);
weaken($self);
- $self-> add_check_content( sub { $self->check_unused_licenses(@_);} )
+ $self-> add_check_content( sub { $self->check_unused_licenses(@_);} );
+ return;
}
sub check_idx { ## no critic (RequireArgUnpacking)
@@ -88,6 +89,7 @@ sub check_unused_licenses ($self,$error, $warn, $fix = 0, $silent = 0) {
my $msg = "Unused license: @unused";
push $warn->@*, $msg;
+ return;
}
sub prune_unused_licenses ($self, $silent = 0) {
@@ -100,5 +102,6 @@ sub prune_unused_licenses ($self, $silent = 0) {
foreach my $lic (@unused) {
$self->delete("$lic");
}
+ return;
}
1;