fix issues shown by perl-critic

3 files changed, 6 insertions, 4 deletions

diff --git a/lib/Config/Model/Dpkg.pm b/lib/Config/Model/Dpkg.pm
index 06047041..a45dc18d 100644
--- a/lib/Config/Model/Dpkg.pm
+++ b/lib/Config/Model/Dpkg.pm
@@ -1,6 +1,7 @@
 package Config::Model::Dpkg;
 
-our $VERSION='2.057';
+use strict;
+use warnings;
 
 1;
 
diff --git a/lib/Config/Model/Dpkg/Copyright.pm b/lib/Config/Model/Dpkg/Copyright.pm
index d22bd26e..32a8f875 100644
--- a/lib/Config/Model/Dpkg/Copyright.pm
+++ b/lib/Config/Model/Dpkg/Copyright.pm
@@ -26,8 +26,9 @@ sub get_joined_path ($self, $paths) {
 }
 
 sub split_path ($self,$path) {
-    return  sort ( ref $path ? @$path : split ( /[\s\n]+/ , $path ) );
+    return ( sort ( ref $path ? @$path : split ( /[\s\n]+/ , $path ) ) );
 }
+
 sub normalize_path ($self,$path) {
     my @paths = $self->split_path($path);
     return $self->get_joined_path(\@paths);
diff --git a/lib/Dpkg/Copyright/Scanner.pm b/lib/Dpkg/Copyright/Scanner.pm
index 2671efec..1ac871e1 100644
--- a/lib/Dpkg/Copyright/Scanner.pm
+++ b/lib/Dpkg/Copyright/Scanner.pm
@@ -83,7 +83,7 @@ sub print_copyright ( %args ) {
         $args{out}->spew_utf8( @out);
     }
     else {
-        binmode(STDOUT, ":utf8");
+        binmode(STDOUT, ":encoding(UTF-8)");
         print @out;
     }
 }
@@ -163,7 +163,7 @@ $default{check} = << 'EOR2' ;
 EOR2
 
 # cleanup the regexp
-map { s/#.*\n//g;  s/[\s\n]+//g; } values %default;
+for (values %default) { s/#.*\n//g;  s/[\s\n]+//g; };
 
 sub _get_data_from_files  ( %args ) {
     my $current_dir = $args{from_dir} || path('.');