Release

Excel::ValueReader::XLSX will not support data and data-refs

7 files changed, 49 insertions, 41 deletions

diff --git a/Changes b/Changes
index 3d6a8fa..7a75f3a 100644
--- a/Changes
+++ b/Changes
@@ -1,4 +1,4 @@
-0.88	- 02 Nov 2023, H.Merijn Brand
+0.88	- 07 Nov 2023, H.Merijn Brand
     * Guard $_ globbering from external bitrotted code
     * Use recommended and suggested versions based on known CVEs
     * Improve user feedback on failing xlsx2csv & xlscat
diff --git a/Read.pm b/Read.pm
index aa34e1b..98e1dd7 100755
--- a/Read.pm
+++ b/Read.pm
@@ -64,7 +64,7 @@ my @parsers = (
     [ xlsx	=> "Spreadsheet::ParseXLSX",	"0.24"	],
     [ xlsm	=> "Spreadsheet::ParseXLSX",	"0.24"	],
     [ xlsx	=> "Spreadsheet::XLSX",		"0.13"	],
-    [ xlsx	=> "Excel::ValueReader::XLSX",	"1.10"	],
+    [ xlsx	=> "Excel::ValueReader::XLSX",	"1.13"	],
 #   [ prl	=> "Spreadsheet::Perl",		""	],
     [ sc	=> "Spreadsheet::Read",		"0.01"	],
     [ gnumeric	=> "Spreadsheet::ReadGnumeric",	"0.2"	],
@@ -2651,6 +2651,9 @@ FastXLSX library.
 This is SAX based parser, so you can parse very large XLSX file with
 lower memory usage.
 
+Last commit 2021-02-16, so I will take PR's but won't do it myself as
+there seems to be little gain in supporting this.
+
 =back
 
 =item Other spreadsheet formats
@@ -2723,8 +2726,8 @@ documentation.
 
 This module aims at speed-reading ignoring all attributes and formatting.
 
-Using this backend does not (yet) support parsing strings, string-refs, IO handles
-or globs. Only filenames are supported.
+Using this backend does not, and will not, support parsing strings, string-refs,
+or globs. Only filenames and file handles are supported.
 
 =item Spreadsheet::ParseODS
 
diff --git a/doc/Spreadsheet-Read.3 b/doc/Spreadsheet-Read.3
index 2b6df3d..477c35c 100644
--- a/doc/Spreadsheet-Read.3
+++ b/doc/Spreadsheet-Read.3
@@ -55,7 +55,7 @@
 .\" ========================================================================
 .\"
 .IX Title "STDIN 1"
-.TH STDIN 1 2023-11-02 "perl v5.38.0" "User Contributed Perl Documentation"
+.TH STDIN 1 2023-11-07 "perl v5.38.0" "User Contributed Perl Documentation"
 .\" For nroff, turn off justification.  Always turn off hyphenation; it makes
 .\" way too many mistakes in technical documents.
 .if n .ad l
@@ -1267,6 +1267,9 @@ FastXLSX library.
 .Sp
 This is SAX based parser, so you can parse very large XLSX file with
 lower memory usage.
+.Sp
+Last commit 2021\-02\-16, so I will take PR's but won't do it myself as
+there seems to be little gain in supporting this.
 .RE
 .RS 4
 .RE
@@ -1329,8 +1332,8 @@ documentation.
 .Sp
 This module aims at speed-reading ignoring all attributes and formatting.
 .Sp
-Using this backend does not (yet) support parsing strings, string-refs, IO handles
-or globs. Only filenames are supported.
+Using this backend does not, and will not, support parsing strings, string-refs,
+or globs. Only filenames and file handles are supported.
 .IP Spreadsheet::ParseODS 2
 .IX Item "Spreadsheet::ParseODS"
 Spreadsheet::ParseODS <https://metacpan.org/pod/Spreadsheet::ParseODS> is a
diff --git a/doc/Spreadsheet-Read.html b/doc/Spreadsheet-Read.html
index d05f0c2..f54340e 100644
--- a/doc/Spreadsheet-Read.html
+++ b/doc/Spreadsheet-Read.html
@@ -1054,6 +1054,8 @@ Unless -A is used, all other options are passed on to xlscat</code></pre>
 
 <p>This is SAX based parser, so you can parse very large XLSX file with lower memory usage.</p>
 
+<p>Last commit 2021-02-16, so I will take PR&#39;s but won&#39;t do it myself as there seems to be little gain in supporting this.</p>
+
 </dd>
 </dl>
 
@@ -1129,7 +1131,7 @@ Unless -A is used, all other options are passed on to xlscat</code></pre>
 
 <p>This module aims at speed-reading ignoring all attributes and formatting.</p>
 
-<p>Using this backend does not (yet) support parsing strings, string-refs, IO handles or globs. Only filenames are supported.</p>
+<p>Using this backend does not, and will not, support parsing strings, string-refs, or globs. Only filenames and file handles are supported.</p>
 
 </dd>
 <dt id="Spreadsheet::ParseODS">Spreadsheet::ParseODS</dt>
diff --git a/doc/Spreadsheet-Read.man b/doc/Spreadsheet-Read.man
index e379789..abee4a6 100644
--- a/doc/Spreadsheet-Read.man
+++ b/doc/Spreadsheet-Read.man
@@ -1040,8 +1040,11 @@ TODO
              This  is  SAX based parser, so you can parse very large XLSX file
              with lower memory usage.
 
+             Last commit 2021-02-16, so I will  take  PR's  but  won't  do  it
+             myself as there seems to be little gain in supporting this.
+
        Other spreadsheet formats
-           I consider adding any spreadsheet interface that  offers  a  usable
+           I  consider  adding  any spreadsheet interface that offers a usable
            API.
 
            Under investigation:
@@ -1055,23 +1058,23 @@ TODO
 
        Alternative parsers for existing formats
            As long as the alternative has a good reason for its existence, and
-           the  API  of  that  parser  reasonable  fits in my approach, I will
-           consider to implement the glue layer, or apply patches to do so  as
+           the API of that parser reasonable  fits  in  my  approach,  I  will
+           consider  to implement the glue layer, or apply patches to do so as
            long as these match what CONTRIBUTING.md describes.
 
 SEE ALSO
        Text::CSV_XS, Text::CSV_PP
-         See    Text::CSV_XS    <https://metacpan.org/release/Text-CSV_XS>   ,
-         Text::CSV_PP <https://metacpan.org/release/Text-CSV> , and  Text::CSV
+         See   Text::CSV_XS    <https://metacpan.org/release/Text-CSV_XS>    ,
+         Text::CSV_PP  <https://metacpan.org/release/Text-CSV> , and Text::CSV
          <https://metacpan.org/release/Text-CSV> documentation.
 
-         Text::CSV  <https://metacpan.org/release/Text-CSV>  is a wrapper over
-         Text::CSV_XS   (the   fast   XS    version)    and/or    Text::CSV_PP
+         Text::CSV <https://metacpan.org/release/Text-CSV> is a  wrapper  over
+         Text::CSV_XS    (the    fast    XS   version)   and/or   Text::CSV_PP
          <https://metacpan.org/release/Text-CSV> (the pure perl version).
 
        Spreadsheet::ParseExcel
          Spreadsheet::ParseExcel    <https://metacpan.org/release/Spreadsheet-
-         ParseExcel> is the best parser for old-style Microsoft  Excel  (.xls)
+         ParseExcel>  is  the best parser for old-style Microsoft Excel (.xls)
          files.
 
        Spreadsheet::ParseXLSX
@@ -1087,7 +1090,7 @@ SEE ALSO
          See Spreadsheet::XLSX <https://metacpan.org/release/Spreadsheet-XLSX>
          documentation.
 
-         This module is dead and deprecated. It  is  buggy  and  unmaintained.
+         This  module  is  dead  and deprecated. It is buggy and unmaintained.
          Please                   use                   Spreadsheet::ParseXLSX
          <https://metacpan.org/release/Spreadsheet-ParseXLSX> instead.
 
@@ -1098,24 +1101,24 @@ SEE ALSO
          This  module  aims  at  speed-reading  ignoring  all  attributes  and
          formatting.
 
-         Using this backend does not (yet) support  parsing  strings,  string-
-         refs, IO handles or globs. Only filenames are supported.
+         Using  this  backend does not, and will not, support parsing strings,
+         string-refs, or globs. Only filenames and file handles are supported.
 
        Spreadsheet::ParseODS
          Spreadsheet::ParseODS
-         <https://metacpan.org/pod/Spreadsheet::ParseODS>   is  a  parser  for
-         OpenOffice/LibreOffice (.sxc and .ods) spreadsheet files. It  is  the
-         successor                   of                   Spreadsheet::ReadSXC
+         <https://metacpan.org/pod/Spreadsheet::ParseODS>  is  a  parser   for
+         OpenOffice/LibreOffice  (.sxc  and .ods) spreadsheet files. It is the
+         successor                  of                    Spreadsheet::ReadSXC
          <https://metacpan.org/release/Spreadsheet-ReadSXC>.
 
        Spreadsheet::ReadSXC
          Spreadsheet::ReadSXC       <https://metacpan.org/release/Spreadsheet-
-         ReadSXC>  is  a  parser  for  OpenOffice/LibreOffice  (.sxc and .ods)
+         ReadSXC> is a  parser  for  OpenOffice/LibreOffice  (.sxc  and  .ods)
          spreadsheet files.
 
        Spreadsheet::ReadGnumeric
          Spreadsheet::ReadGnumeric  <https://metacpan.org/release/Spreadsheet-
-         ReadGnumeric>  is  a  parser  for Gnumeric <http://www.gnumeric.org/>
+         ReadGnumeric> is a  parser  for  Gnumeric  <http://www.gnumeric.org/>
          (.gnumeric) spreadsheet files.
 
        Spreadsheet::BasicRead
@@ -1128,20 +1131,20 @@ SEE ALSO
 
        Spreadsheet::Perl
          Spreadsheet::Perl     <https://metacpan.org/release/Spreadsheet-Perl>
-         offers  a  Pure  Perl  implementation of a spreadsheet engine.  Users
+         offers a Pure Perl implementation of  a  spreadsheet  engine.   Users
          that want this format to be supported in Spreadsheet::Read are hereby
          motivated to offer patches. It is not high on my TODO-list.
 
        Spreadsheet::CSV
          Spreadsheet::CSV       <https://metacpan.org/release/Spreadsheet-CSV>
-         offers  the  interesting approach of seeing all supported spreadsheet
+         offers the interesting approach of seeing all  supported  spreadsheet
          formats   as   if   it   were   CSV,   mimicking   the   Text::CSV_XS
          <https://metacpan.org/release/Text-CSV_XS> interface.
 
        xls2csv
          xls2csv                          <https://github.com/Tux/Spreadsheet-
-         Read/blob/master/scripts/xls2csv>  offers  an  alternative   for   my
-         "xlscat  -c", in the xls2csv tool, but this tool focuses on character
+         Read/blob/master/scripts/xls2csv>   offers   an  alternative  for  my
+         "xlscat -c", in the xls2csv tool, but this tool focuses on  character
          encoding transparency, and requires some other modules.
 
 AUTHOR
@@ -1153,4 +1156,4 @@ COPYRIGHT AND LICENSE
        This library is free software; you can redistribute it and/or modify it
        under the same terms as Perl itself.
 
-perl v5.38.0                      2023-11-02                          STDIN(1)
+perl v5.38.0                      2023-11-07                          STDIN(1)
diff --git a/doc/Spreadsheet-Read.md b/doc/Spreadsheet-Read.md
index baf4e72..9fbadea 100644
--- a/doc/Spreadsheet-Read.md
+++ b/doc/Spreadsheet-Read.md
@@ -1057,6 +1057,9 @@ Show the differences between two spreadsheets.
         This is SAX based parser, so you can parse very large XLSX file with
         lower memory usage.
 
+        Last commit 2021-02-16, so I will take PR's but won't do it myself as
+        there seems to be little gain in supporting this.
+
 - Other spreadsheet formats
 
     I consider adding any spreadsheet interface that offers a usable API.
@@ -1119,8 +1122,8 @@ Show the differences between two spreadsheets.
 
     This module aims at speed-reading ignoring all attributes and formatting.
 
-    Using this backend does not (yet) support parsing strings, string-refs, IO handles
-    or globs. Only filenames are supported.
+    Using this backend does not, and will not, support parsing strings, string-refs,
+    or globs. Only filenames and file handles are supported.
 
 - Spreadsheet::ParseODS
 
diff --git a/t/630_xlsx.t b/t/630_xlsx.t
index 4a8fa72..1a37bee 100644
--- a/t/630_xlsx.t
+++ b/t/630_xlsx.t
@@ -5,7 +5,7 @@ use warnings;
 
 BEGIN { $ENV{SPREADSHEET_READ_XLSX} = "Excel::ValueReader::XLSX"; }
 
-my     $tests = 128;
+my     $tests = 121;
 use     Test::More;
 require Test::NoWarnings;
 
@@ -33,7 +33,6 @@ my $content;
 
 my $xls;
 foreach my $base ( [ "files/test.xlsx",	"Read/Parse xlsx file"	],
-#		   [ $content,		"Parse xlsx data"	],
 		   ) {
     my ($txt, $msg) = @$base;
     ok ($xls = ReadData ($txt),	$msg);
@@ -168,14 +167,9 @@ is ($ss->{F1},		"",    "formatted a single '");
     my $data = $content;
     open my $fh, "<", "files/test.xlsx";
 
-    SKIP: { skip "NYI: support for file handles", 3; ok (0) for 1..3 };
-#   chk_test ( " FH    parser",    ReadData ( $fh,   parser => "xlsx")); close $fh;
-    SKIP: { skip "NYI: support for data ref",     3; ok (0) for 1..3 };
-#   chk_test ("\\DATA  parser",    ReadData (\$data, parser => "xlsx"));
-    SKIP: { skip "NYI: support for data string",  3; ok (0) for 1..3 };
-#   chk_test ( " DATA  no parser", ReadData ( $data                  ));
-    SKIP: { skip "NYI: support for data string",  3; ok (0) for 1..3 };
-#   chk_test ( " DATA  parser",    ReadData ( $data, parser => "xlsx"));
+    chk_test ( " FH    parser",    ReadData ( $fh,   parser => "xlsx")); close $fh;
+    SKIP: { skip "No support for data ref",     1; ok (0) };
+    SKIP: { skip "No support for data string",  1; ok (0) };
     }
 
 unless ($ENV{AUTOMATED_TESTING}) {