Revert "Reduce indentation depth using C99"

This reverts commit c4d20840f3487588c4a0da4397b1acb6dc83a1e5.  Even in
C99, a declaration isn't valid immediately after a label; this didn't
become valid until C2x, although gcc allows it as an extension.

Fixes https://gitlab.com/cjwatson/man-db/-/issues/2.

* src/man.c (parse_opt): Restore enclosing block for OPT_WARNINGS.
* NEWS: Document this.

1 files changed, 10 insertions, 7 deletions

diff --git a/src/man.c b/src/man.c
index c91abf15..5d5caaf1 100644
--- a/src/man.c
+++ b/src/man.c
@@ -383,15 +383,18 @@ static error_t parse_opt (int key, char *arg, struct argp_state *state)
 
 		case OPT_WARNINGS:
 #ifdef NROFF_WARNINGS
-			char *s = xstrdup (arg ? arg : default_roff_warnings);
-			const char *warning;
+			{
+				char *s = xstrdup
+					(arg ? arg : default_roff_warnings);
+				const char *warning;
 
-			for (warning = strtok (s, ","); warning;
-			     warning = strtok (NULL, ","))
-				gl_list_add_last (roff_warnings,
-						  xstrdup (warning));
+				for (warning = strtok (s, ","); warning;
+				     warning = strtok (NULL, ","))
+					gl_list_add_last (roff_warnings,
+							  xstrdup (warning));
 
-			free (s);
+				free (s);
+			}
 #endif /* NROFF_WARNINGS */
 			return 0;