diff options
| author | mwilck@arcor.de <mwilck@arcor.de> | 2013-09-24 20:53:18 +0200 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2013-10-16 15:31:30 +1100 |
| commit | a4921f30ec2ecc2d685573899cb86064b0cd78e9 (patch) | |
| tree | 87c956a483205012d56e63af5059ee2927b6c00a | |
| parent | 21529ab377875997f3a974244fb9933e69e2dd97 (diff) | |
Monitor: write meta data in readonly state, sometimes
This patch reverts 24a216bf:
"Monitor: Don't write metadata in inactive array state".
While it's true that writing meta data is usually not necessary
in readonly state, there is one important exception: if a
disk goes faulty, we want to record that, even if the array is
inactive.
We might as well just revert 24a216bf, because with the recently
submitted patch
"Monitor: don't set arrays dirty after transition to read-only"
those meta data writes that really annoying (for a clean, readonly,
healthy array during startup) are gone anyway.
Signed-off-by: Martin Wilck <mwilck@arcor.de>
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | monitor.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -421,8 +421,7 @@ static int read_and_act(struct active_array *a) if (sync_completed > a->last_checkpoint) a->last_checkpoint = sync_completed; - if (deactivate || a->curr_state >= clean) - a->container->ss->sync_metadata(a->container); + a->container->ss->sync_metadata(a->container); dprintf("%s(%d): state:%s action:%s next(", __func__, a->info.container_member, array_states[a->curr_state], sync_actions[a->curr_action]); |