diff options
| author | NeilBrown <neilb@suse.de> | 2014-07-03 15:04:01 +1000 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2014-07-03 15:04:01 +1000 |
| commit | 6d8d290a2f09a3bfd9e44f382ae5daea128772f7 (patch) | |
| tree | 8b69dc82c8a01cb0daff9cfef0e8cf728d4abc30 | |
| parent | e339dba2a1744dc6860a58e286ded39fc993c2db (diff) | |
IMSM: use strcpy rather than pointless strncpy.
As strncpy doesn't guarantee to nul-terminate, some static
analysers get upset that it is followed by a 'strncat'.
So just use a 'strcpy' - strlen(disk_by_path) is constant
and definitely less than PATH_MAX.
Link: https://github.com/neilbrown/mdadm/issues/4
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | super-intel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/super-intel.c b/super-intel.c index 9dd807ac..0106b4f6 100644 --- a/super-intel.c +++ b/super-intel.c @@ -9357,7 +9357,7 @@ static const char *imsm_get_disk_controller_domain(const char *path) char *drv=NULL; struct stat st; - strncpy(disk_path, disk_by_path, PATH_MAX - 1); + strcpy(disk_path, disk_by_path); strncat(disk_path, path, PATH_MAX - strlen(disk_path) - 1); if (stat(disk_path, &st) == 0) { struct sys_dev* hba; |