summaryrefslogtreecommitdiff
path: root/ANNOUNCE-3.2.5
diff options
context:
space:
mode:
authorLukasz Dorau <lukasz.dorau@intel.com>2012-05-25 15:06:41 +0200
committerNeilBrown <neilb@suse.de>2012-05-29 09:34:39 +1000
commite1993023991a6fa6539cc604b4b3d6718833250d (patch)
tree2e88dd985b712d70fcdb4f51940de5b022eaf09b /ANNOUNCE-3.2.5
parent4687f160276a8f7815675ca758c598d881f04fd7 (diff)
imsm: fix: correct checking volume's degradation
We do not check the return value of sysfs_get_ll() now. It is wrong. If reading of the sysfs "degraded" key does not succeed, the "new_degraded" variable will not be initiated and accidentally it can have the value of "degraded" variable. In that case the change of degradation will not be checked. It happens if mdadm is compiled with gcc's "-fstack-protector" option when one tries to stop a volume under reshape (e.g. OLCE). Reshape seems to be finished then (metadata is in normal/clean state) but it is not finished, it is broken and data are corrupted. Now we always check the return value of sysfs_get_ll(). Even if reading of the sysfs "degraded" key does not succeed (rv == -1) the change of degradation will be checked. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com> Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'ANNOUNCE-3.2.5')
0 files changed, 0 insertions, 0 deletions