diff options
| author | NeilBrown <neilb@suse.de> | 2011-12-20 10:30:34 +1100 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2011-12-20 10:30:34 +1100 |
| commit | 81a5b4f52f0697f3c494c7ee2723e5f833b9ec51 (patch) | |
| tree | 3160324570095e5bbc4fb8beac108e8dddefd18b /Assemble.c | |
| parent | 67a2db324f61326157373117c78a8314c7d220e4 (diff) | |
Remove update_private
This fields doesn't work any more as ->getinfo_super clears the info
structure at an awkward time. So get rid of it and do it differently.
The issue is that the metadata handler cannot tell if the uuid it has
was randomly generated or explicitly requested, except on the first
call.
And we don't want to accept explicit requests for IMSM.
So when it was auto-generated, make it look distinctive by having the
same int copied in all 4 positions. If someone requests a uuid like
that, I guess they get away with it.
Reported-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'Assemble.c')
| -rw-r--r-- | Assemble.c | 3 |
1 files changed, 0 insertions, 3 deletions
@@ -706,7 +706,6 @@ int Assemble(struct supertype *st, char *mddev, bitmap_done = 0; #endif /* Ok, no bad inconsistancy, we can try updating etc */ - content->update_private = NULL; devices = malloc(num_devs * sizeof(*devices)); devmap = calloc(num_devs * content->array.raid_disks, 1); for (tmpdev = devlist; tmpdev; tmpdev=tmpdev->next) if (tmpdev->used == 1) { @@ -891,8 +890,6 @@ int Assemble(struct supertype *st, char *mddev, } devcnt++; } - free(content->update_private); - content->update_private = NULL; if (devcnt == 0) { fprintf(stderr, Name ": no devices found for %s\n", |