Factor out add-disk code

The variety of approaches to 'add_disk' are factored out into
a separate function, and Incremental mode benefits by being
closer to supporting the assembly of containers.

Also remove the adding-to-array-data-structure out of sysfs_add_disk
and into add_disk.

And add some tests for --incremental mode to make sure we don't break it.

Signed-off-by: NeilBrown <neilb@suse.de>

1 files changed, 1 insertions, 5 deletions

diff --git a/Create.c b/Create.c
index 48d811f2..20886d11 100644
--- a/Create.c
+++ b/Create.c
@@ -714,11 +714,7 @@ int Create(struct supertype *st, char *mddev, int mdfd,
 				inf->errors = 0;
 				rv = 0;
 
-				if (st->ss->external)
-					rv = sysfs_add_disk(sra, inf);
-				else
-					rv = ioctl(mdfd, ADD_NEW_DISK,
-						   &inf->disk);
+				rv = add_disk(mdfd, st, sra, inf);
 
 				if (rv) {
 					fprintf(stderr,