diff options
| author | NeilBrown <neilb@suse.de> | 2010-07-22 15:28:15 +1000 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2010-07-22 15:35:54 +1000 |
| commit | 3e4165619b146d3134838c6546778c02308c462e (patch) | |
| tree | 37c2b8e1ce7f22108671e9fd40d3e22101b7cc27 /Detail.c | |
| parent | 50526e9090d0c118b065840719bc9601be8af8b8 (diff) | |
Cast to long long before left-shifting too much.
When left-shifting we must be sure that the value being
shifted is large enough to not lose bits.
The 'chunkssize' in CreateBitmap is only 'long' so it
can overflow. So cast to 'long long' first.
Also fix a similar issue in Detail even though it isn't currently
being compiled.
Signed-off-by: NeilBrown <neilb@suse.de>
Reported-by: Tomasz Chmielewski <mangoo@wpkg.org>
Diffstat (limited to 'Detail.c')
| -rw-r--r-- | Detail.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -409,7 +409,7 @@ int Detail(char *dev, int brief, int export, int test, char *homehost) #if 0 This is pretty boring printf(" Reshape pos'n : %llu%s\n", (unsigned long long) info.reshape_progress<<9, - human_size(info.reshape_progress<<9)); + human_size((unsigned long long)info.reshape_progress<<9)); #endif if (info.delta_disks > 0) printf(" Delta Devices : %d, (%d->%d)\n", |