summaryrefslogtreecommitdiff
path: root/Grow.c
diff options
context:
space:
mode:
authorJes Sorensen <Jes.Sorensen@redhat.com>2013-07-30 18:30:03 +0200
committerNeilBrown <neilb@suse.de>2013-07-31 08:51:16 +1000
commit364a48c9923c5164af848467c77aece080ba74fc (patch)
tree0758f431fd362f9a0e465c4b9aa2537eb7fbfef1 /Grow.c
parent23bf42cc79d46de019d4b27c16354a191a98ed41 (diff)
Avoid double close()
Coverity discovered a possible double close(fd2) in Grow.c. Avoided by invalidating fd2 after the first close. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'Grow.c')
-rw-r--r--Grow.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/Grow.c b/Grow.c
index c1ae6e83..ff4ed5dd 100644
--- a/Grow.c
+++ b/Grow.c
@@ -4685,6 +4685,8 @@ int Grow_continue_command(char *devname, int fd,
continue;
err = st->ss->load_super(st, fd2, NULL);
close(fd2);
+ /* invalidate fd2 to avoid possible double close() */
+ fd2 = -1;
if (err)
continue;
break;