diff options
author | NeilBrown <neilb@suse.de> | 2010-08-05 13:13:02 +1000 |
---|---|---|
committer | NeilBrown <neilb@suse.de> | 2010-08-05 13:13:02 +1000 |
commit | f21e18ca8969f21549c646096f354eac57cd53a8 (patch) | |
tree | 5e0b0474075ba8f629860964914fe18a6892ccd4 /restripe.c | |
parent | 9aaada0530396078063b17d138beb74fcbcfeebc (diff) |
Compile with -Wextra by default
This produced lots of warning, some of which pointed to actual bugs.
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'restripe.c')
-rw-r--r-- | restripe.c | 8 |
1 files changed, 5 insertions, 3 deletions
@@ -583,7 +583,7 @@ int restore_stripes(int *dest, unsigned long long *offsets, for (i=0; i<raid_disks; i++) stripes[i] = stripe_buf + i * chunk_size; while (length > 0) { - int len = data_disks * chunk_size; + unsigned int len = data_disks * chunk_size; unsigned long long offset; int disk, qdisk; int syndrome_disks; @@ -592,9 +592,11 @@ int restore_stripes(int *dest, unsigned long long *offsets, for (i=0; i < data_disks; i++) { int disk = geo_map(i, start/chunk_size/data_disks, raid_disks, level, layout); - if (lseek64(source, read_offset, 0) != read_offset) + if ((unsigned long long)lseek64(source, read_offset, 0) + != read_offset) return -1; - if (read(source, stripes[disk], chunk_size) != chunk_size) + if (read(source, stripes[disk], + chunk_size) != chunk_size) return -1; read_offset += chunk_size; } |