diff options
| author | NeilBrown <neilb@suse.de> | 2014-05-21 13:50:52 +1000 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2014-05-21 13:50:52 +1000 |
| commit | 98fbc0ff37611260210bac0ba63dacee8d80feac (patch) | |
| tree | 1e8ab44dc6b0d93fa417c3c411fb9180e41975cf /super-ddf.c | |
| parent | de9107744bff1d59103858db06b2ba1811cb683f (diff) | |
DDF: remove 'FIXME' comment that doesn't need fixing.
It appears this is correct, though for consistency with elsewhere
we check that pdnum is not negative.
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'super-ddf.c')
| -rw-r--r-- | super-ddf.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/super-ddf.c b/super-ddf.c index 607f1ea1..e78e1385 100644 --- a/super-ddf.c +++ b/super-ddf.c @@ -4403,8 +4403,9 @@ static void ddf_set_disk(struct active_array *a, int n, int state) dprintf("%s: array %u disk %u ref %08x pd %d\n", __func__, inst, n_bvd, be32_to_cpu(vc->phys_refnum[n_bvd]), pd); - if ((state & DS_INSYNC) && ! (state & DS_FAULTY)) { - pd = dl->pdnum; /* FIXME: is this really correct ? */ + if ((state & DS_INSYNC) && ! (state & DS_FAULTY) && + dl->pdnum >= 0) { + pd = dl->pdnum; vc->phys_refnum[n_bvd] = dl->disk.refnum; LBA_OFFSET(ddf, vc)[n_bvd] = cpu_to_be64(mdi->data_offset); |