diff options
| author | Adam Kwolek <adam.kwolek@intel.com> | 2011-01-28 14:37:51 +0100 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2011-01-31 11:06:42 +1100 |
| commit | cb82edca142b22b005a035a2f9678c3606e60339 (patch) | |
| tree | 246864b2e237d11d156be4f80e2e6e4a7d51d28d /super-intel.c | |
| parent | a1e49d6956c0aa0a2accf77f79841dd4d5b69560 (diff) | |
imsm: FIX: not all disks are released in free_imsm_disks()
Adding spare disks to imsm container fails due to problem with writing
new_dev to sysfs. This problem was caused by not closed handle
(opened exclusively) in Manage.c:803.
Disk handle was not closed by free_imsm().
This is due to not released disk_mgmt_list in free_imsm_disks().
Proper release of imsm metadata allows for spare adding without problems.
Memory leak was fixed also.
Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'super-intel.c')
| -rw-r--r-- | super-intel.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/super-intel.c b/super-intel.c index cc471991..f578057d 100644 --- a/super-intel.c +++ b/super-intel.c @@ -2687,6 +2687,11 @@ static void free_imsm_disks(struct intel_super *super) super->disks = d->next; __free_imsm_disk(d); } + while (super->disk_mgmt_list) { + d = super->disk_mgmt_list; + super->disk_mgmt_list = d->next; + __free_imsm_disk(d); + } while (super->missing) { d = super->missing; super->missing = d->next; |