summaryrefslogtreecommitdiff
path: root/super0.c
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2013-07-30 13:45:22 +1000
committerNeilBrown <neilb@suse.de>2013-07-30 13:45:22 +1000
commit7ccc4cc4fc6889680bbe4ec673cab3f6aa49aad3 (patch)
tree509af03e40d95c181cf35d9c9ec673d8c913b191 /super0.c
parent0c78849f2bde13309f5df7130627f8589024a266 (diff)
Manage: remove call to validate_geometry.
This call to validate_geometry is really rather gratuitous. It is purely about the fact that super0 cannot use more than 4TB. So just make it an explicit test - less confusing that way. With this, validate_geometry is only called from Create, which makes it easier to reason about. Also validate_geometry is now never passed NULL for the 'chunk' parameter, so we can remove those annoying tests for NULL. Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'super0.c')
-rw-r--r--super0.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/super0.c b/super0.c
index 85acf368..3218377f 100644
--- a/super0.c
+++ b/super0.c
@@ -1274,7 +1274,7 @@ static int validate_geometry0(struct supertype *st, int level,
"%d terabytes per device\n", tbmax);
return 0;
}
- if (chunk && *chunk == UnSet)
+ if (*chunk == UnSet)
*chunk = DEFAULT_CHUNK;
if (!subdev)