From e9b11feec86972ee9a1afab4b6fb63d93221484b Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Tue, 10 May 2011 17:58:41 +1000 Subject: Create: give better error message if member device unusable. Rather than just saying "unusable", report if device is busy or is no a block device. Signed-off-by: NeilBrown --- Create.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'Create.c') diff --git a/Create.c b/Create.c index ef60244a..fb7f2289 100644 --- a/Create.c +++ b/Create.c @@ -292,6 +292,8 @@ int Create(struct supertype *st, char *mddev, for (dv=devlist; dv && !have_container; dv=dv->next, dnum++) { char *dname = dv->devname; unsigned long long freesize; + int dfd; + if (strcasecmp(dname, "missing")==0) { if (first_missing > dnum) first_missing = dnum; @@ -300,6 +302,20 @@ int Create(struct supertype *st, char *mddev, missing_disks ++; continue; } + dfd = open(dname, O_RDONLY|O_EXCL); + if (dfd < 0) { + fprintf(stderr, Name ": cannot open %s: %s\n", + dname, strerror(errno)); + exit(2); + } + if (fstat(dfd, &stb) != 0 || + (stb.st_mode & S_IFMT) != S_IFBLK) { + close(dfd); + fprintf(stderr, Name ": %s is not a block device\n", + dname); + exit(2); + } + close(dfd); info.array.working_disks++; if (dnum < raiddisks) info.array.active_disks++; -- cgit v1.2.3