From cff33b6413b03978d6289542f9aec790f0785783 Mon Sep 17 00:00:00 2001 From: Thorsten Kukuk Date: Tue, 20 Sep 2005 08:31:27 +0000 Subject: Relevant BUGIDs: none Purpose of commit: bugfix Commit summary: --------------- Fix missing NULL pointer check and us asprintf instead of malloc/snprintf (from Dmitry V. Levin). --- libpam_misc/help_env.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'libpam_misc') diff --git a/libpam_misc/help_env.c b/libpam_misc/help_env.c index 2b800283..601c5f41 100644 --- a/libpam_misc/help_env.c +++ b/libpam_misc/help_env.c @@ -5,6 +5,8 @@ * */ +#include "config.h" + #include #include #include @@ -72,9 +74,7 @@ int pam_misc_setenv(pam_handle_t *pamh, const char *name return PAM_PERM_DENIED; /* not allowed to overwrite */ } } - tmp = malloc(2+strlen(name)+strlen(value)); - if (tmp != NULL) { - sprintf(tmp,"%s=%s",name,value); + if (asprintf(&tmp, "%s=%s", name, value) >= 0) { D(("pam_putt()ing: %s", tmp)); retval = pam_putenv(pamh, tmp); _pam_overwrite(tmp); /* purge */ -- cgit v1.2.3