From c2c0434bd634a817f2b16ce7f58fc96c04e88b03 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Sun, 26 Apr 2020 11:12:59 +0000 Subject: pam_motd: fix NULL dereference when at least one of motd directories is not available * modules/pam_motd/pam_motd.c (try_to_display_directories_with_overrides): Do not assign -1U to dirscans_sizes[i] when scandir(motd_dir_path_split[i]) returns an error. Resolves: https://bugzilla.altlinux.org/38389 Fixes: d57ab221 ("pam_motd: Cleanup the code and avoid unnecessary logging") --- modules/pam_motd/pam_motd.c | 1 + 1 file changed, 1 insertion(+) (limited to 'modules/pam_motd') diff --git a/modules/pam_motd/pam_motd.c b/modules/pam_motd/pam_motd.c index df09b7d0..8147c6fd 100644 --- a/modules/pam_motd/pam_motd.c +++ b/modules/pam_motd/pam_motd.c @@ -219,6 +219,7 @@ static void try_to_display_directories_with_overrides(pam_handle_t *pamh, pam_syslog(pamh, LOG_ERR, "error scanning directory %s: %m", motd_dir_path_split[i]); } + } else { dirscans_sizes[i] = rv; } dirscans_size_total += dirscans_sizes[i]; -- cgit v1.2.3