From 83d378e6cc1635621803d2adc613378bd3847dd0 Mon Sep 17 00:00:00 2001
From: "Dmitry V. Levin" <ldv@altlinux.org>
Date: Mon, 16 Mar 2020 21:02:18 +0000
Subject: modules/pam_nologin: use pam_str_skip_prefix

* modules/pam_nologin/pam_nologin.c: Include "pam_inline.h".
(parse_args): Use pam_str_skip_prefix instead of ugly strncmp
invocations.
---
 modules/pam_nologin/pam_nologin.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

(limited to 'modules/pam_nologin/pam_nologin.c')

diff --git a/modules/pam_nologin/pam_nologin.c b/modules/pam_nologin/pam_nologin.c
index 56897670..775dda87 100644
--- a/modules/pam_nologin/pam_nologin.c
+++ b/modules/pam_nologin/pam_nologin.c
@@ -32,6 +32,7 @@
 #include <security/pam_modules.h>
 #include <security/pam_modutil.h>
 #include <security/pam_ext.h>
+#include "pam_inline.h"
 
 #define DEFAULT_NOLOGIN_PATH "/var/run/nologin"
 #define COMPAT_NOLOGIN_PATH "/etc/nologin"
@@ -54,10 +55,12 @@ parse_args(pam_handle_t *pamh, int argc, const char **argv, struct opt_s *opts)
     opts->retval_when_nofile = PAM_IGNORE;
 
     for (i=0; i<argc; ++i) {
+	const char *str;
+
 	if (!strcmp("successok", argv[i])) {
 	    opts->retval_when_nofile = PAM_SUCCESS;
-	} else if (!strncmp("file=", argv[i], 5)) {
-	    opts->nologin_file = argv[i] + 5;
+	} else if ((str = pam_str_skip_prefix(argv[i], "file=")) != NULL) {
+	    opts->nologin_file = str;
 	} else {
 	    pam_syslog(pamh, LOG_ERR, "unknown option: %s", argv[i]);
 	}
-- 
cgit v1.2.3