From dce30cd7a07523b0937e7a2cbb83fe744bdbfcf0 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Tue, 14 Jun 2016 23:03:13 +0000 Subject: pam_timestamp: fix typo in strncmp usage Before this fix, a typo in check_login_time resulted to ruser and struct utmp.ut_user being compared by the first character only, which in turn could lead to a too low timestamp value being assigned to oldest_login, effectively causing bypass of check_login_time. * modules/pam_timestamp/pam_timestamp.c (check_login_time): Fix typo in strncmp usage. Patch-by: Anton V. Boyarshinov --- modules/pam_timestamp/pam_timestamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'modules/pam_timestamp/pam_timestamp.c') diff --git a/modules/pam_timestamp/pam_timestamp.c b/modules/pam_timestamp/pam_timestamp.c index b18efdfd..aa8e7811 100644 --- a/modules/pam_timestamp/pam_timestamp.c +++ b/modules/pam_timestamp/pam_timestamp.c @@ -211,7 +211,7 @@ check_login_time(const char *ruser, time_t timestamp) if (ut->ut_type != USER_PROCESS) { continue; } - if (strncmp(ruser, ut->ut_user, sizeof(ut->ut_user) != 0)) { + if (strncmp(ruser, ut->ut_user, sizeof(ut->ut_user)) != 0) { continue; } if (oldest_login == 0 || oldest_login > ut->ut_tv.tv_sec) { -- cgit v1.2.3