From 6fefdd6724fc7618a263bb69c03851cc4f46d3fc Mon Sep 17 00:00:00 2001 From: Thorsten Kukuk Date: Mon, 28 Aug 2006 09:50:23 +0000 Subject: Relevant BUGIDs: Purpose of commit: cleanup Commit summary: --------------- 2006-08-28 Thorsten Kukuk * modules/pam_cracklib/pam_cracklib.c (pam_sm_chauthtok): Remove duplicate code. --- modules/pam_cracklib/pam_cracklib.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'modules') diff --git a/modules/pam_cracklib/pam_cracklib.c b/modules/pam_cracklib/pam_cracklib.c index 3ca4eb40..204132d4 100644 --- a/modules/pam_cracklib/pam_cracklib.c +++ b/modules/pam_cracklib/pam_cracklib.c @@ -661,13 +661,10 @@ PAM_EXTERN int pam_sm_chauthtok(pam_handle_t *pamh, int flags, * tidy up the conversation (resp_retcode) is ignored */ _pam_drop(resp); - } else { - if (ctrl && PAM_DEBUG_ARG) - pam_syslog(pamh, LOG_DEBUG, - "unable to obtain the password a second time"); - continue; } + /* No else, the a retval == PAM_SUCCESS path can change retval + to a failure code. */ if (retval != PAM_SUCCESS) { if (ctrl && PAM_DEBUG_ARG) pam_syslog(pamh,LOG_DEBUG,"unable to obtain retyped password"); -- cgit v1.2.3