From 8cfc3e7a9aa7f40aeafe58aa88bc1bfca5282afe Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Tue, 26 Aug 2014 14:08:28 +0200 Subject: pam_mkhomedir: Drop superfluous stat() call. modules/pam_mkhomedir/mkhomedir_helper.c (create_homedir): Drop superfluous stat() call. --- modules/pam_mkhomedir/mkhomedir_helper.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) (limited to 'modules') diff --git a/modules/pam_mkhomedir/mkhomedir_helper.c b/modules/pam_mkhomedir/mkhomedir_helper.c index f426d721..9fafe6ab 100644 --- a/modules/pam_mkhomedir/mkhomedir_helper.c +++ b/modules/pam_mkhomedir/mkhomedir_helper.c @@ -231,7 +231,7 @@ create_homedir(const struct passwd *pwd, if ((srcfd = open(newsource, O_RDONLY)) < 0 || fstat(srcfd, &st) != 0) { pam_syslog(NULL, LOG_DEBUG, - "unable to open src file %s: %m", newsource); + "unable to open or stat src file %s: %m", newsource); closedir(d); #ifndef PATH_MAX @@ -241,20 +241,6 @@ create_homedir(const struct passwd *pwd, return PAM_PERM_DENIED; } - if (stat(newsource, &st) != 0) - { - pam_syslog(NULL, LOG_DEBUG, "unable to stat src file %s: %m", - newsource); - close(srcfd); - closedir(d); - -#ifndef PATH_MAX - free(newsource); newsource = NULL; - free(newdest); newdest = NULL; -#endif - - return PAM_PERM_DENIED; - } /* Open the dest file */ if ((destfd = open(newdest, O_WRONLY | O_TRUNC | O_CREAT, 0600)) < 0) -- cgit v1.2.3