From c7daf2606c535ebb2cd14b6e9aaba3c5894222e2 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Mon, 18 Feb 2008 13:37:46 +0000 Subject: Relevant BUGIDs: Purpose of commit: bugfix Commit summary: --------------- 2008-02-18 Dmitry V. Levin * libpam/pam_handlers.c (_pam_assemble_line): Fix potential buffer overflow. * xtests/tst-pam_assemble_line.pamd: New test for _pam_assemble_line. * xtests/tst-pam_assemble_line.sh: New script for tst-pam_assemble_line. * xtests/Makefile.am (NOSRCTESTS): Add tst-pam_assemble_line. --- xtests/Makefile.am | 2 +- xtests/tst-pam_assemble_line.pamd | 8 ++++++++ xtests/tst-pam_assemble_line.sh | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 xtests/tst-pam_assemble_line.pamd create mode 100644 xtests/tst-pam_assemble_line.sh (limited to 'xtests') diff --git a/xtests/Makefile.am b/xtests/Makefile.am index 62e32643..05aa7050 100644 --- a/xtests/Makefile.am +++ b/xtests/Makefile.am @@ -38,7 +38,7 @@ XTESTS = tst-pam_dispatch1 tst-pam_dispatch2 tst-pam_dispatch3 \ tst-pam_group1 tst-pam_authfail tst-pam_authsucceed NOSRCTESTS = tst-pam_substack1 tst-pam_substack2 tst-pam_substack3 \ - tst-pam_substack4 tst-pam_substack5 + tst-pam_substack4 tst-pam_substack5 tst-pam_assemble_line noinst_PROGRAMS = $(XTESTS) diff --git a/xtests/tst-pam_assemble_line.pamd b/xtests/tst-pam_assemble_line.pamd new file mode 100644 index 00000000..431b3ba1 --- /dev/null +++ b/xtests/tst-pam_assemble_line.pamd @@ -0,0 +1,8 @@ +#%PAM-1.0 +# Test that _pam_assemble_line() does not crash with long lines. +# printf '%511s\\\n%511s\\\n%511s\\\n%511s\\\n' + \ + \ + \ + \ +auth required pam_deny.so diff --git a/xtests/tst-pam_assemble_line.sh b/xtests/tst-pam_assemble_line.sh new file mode 100644 index 00000000..076b51c0 --- /dev/null +++ b/xtests/tst-pam_assemble_line.sh @@ -0,0 +1,3 @@ +#!/bin/bash + +exec ./tst-pam_authfail tst-pam_assemble_line -- cgit v1.2.3 From 9334a8d3db4f8021da1fe9f235257f1b20a2b7d0 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Mon, 18 Feb 2008 15:25:09 +0000 Subject: Relevant BUGIDs: Purpose of commit: bugfix Commit summary: --------------- 2008-02-18 Dmitry V. Levin * xtests/Makefile.am (EXTRA_DIST): Add tst-pam_assemble_line.pamd and tst-pam_assemble_line.sh --- xtests/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'xtests') diff --git a/xtests/Makefile.am b/xtests/Makefile.am index 05aa7050..a6670e30 100644 --- a/xtests/Makefile.am +++ b/xtests/Makefile.am @@ -27,7 +27,8 @@ EXTRA_DIST = run-xtests.sh tst-pam_dispatch1.pamd tst-pam_dispatch2.pamd \ tst-pam_substack2.pamd tst-pam_substack2a.pamd tst-pam_substack2.sh \ tst-pam_substack3.pamd tst-pam_substack3a.pamd tst-pam_substack3.sh \ tst-pam_substack4.pamd tst-pam_substack4a.pamd tst-pam_substack4.sh \ - tst-pam_substack5.pamd tst-pam_substack5a.pamd tst-pam_substack5.sh + tst-pam_substack5.pamd tst-pam_substack5a.pamd tst-pam_substack5.sh \ + tst-pam_assemble_line.pamd tst-pam_assemble_line.sh XTESTS = tst-pam_dispatch1 tst-pam_dispatch2 tst-pam_dispatch3 \ tst-pam_dispatch4 tst-pam_dispatch5 \ -- cgit v1.2.3 From 9058692366a17701a67d4a5c2eb306acfc778bd6 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Mon, 18 Feb 2008 17:57:34 +0000 Subject: Relevant BUGIDs: Purpose of commit: cleanup Commit summary: --------------- Rename tst-pam_assemble_line to tst-pam_assemble_line1 --- xtests/Makefile.am | 4 ++-- xtests/tst-pam_assemble_line.pamd | 8 -------- xtests/tst-pam_assemble_line.sh | 3 --- xtests/tst-pam_assemble_line1.pamd | 8 ++++++++ xtests/tst-pam_assemble_line1.sh | 3 +++ 5 files changed, 13 insertions(+), 13 deletions(-) delete mode 100644 xtests/tst-pam_assemble_line.pamd delete mode 100644 xtests/tst-pam_assemble_line.sh create mode 100644 xtests/tst-pam_assemble_line1.pamd create mode 100755 xtests/tst-pam_assemble_line1.sh (limited to 'xtests') diff --git a/xtests/Makefile.am b/xtests/Makefile.am index a6670e30..30a923aa 100644 --- a/xtests/Makefile.am +++ b/xtests/Makefile.am @@ -28,7 +28,7 @@ EXTRA_DIST = run-xtests.sh tst-pam_dispatch1.pamd tst-pam_dispatch2.pamd \ tst-pam_substack3.pamd tst-pam_substack3a.pamd tst-pam_substack3.sh \ tst-pam_substack4.pamd tst-pam_substack4a.pamd tst-pam_substack4.sh \ tst-pam_substack5.pamd tst-pam_substack5a.pamd tst-pam_substack5.sh \ - tst-pam_assemble_line.pamd tst-pam_assemble_line.sh + tst-pam_assemble_line1.pamd tst-pam_assemble_line1.sh XTESTS = tst-pam_dispatch1 tst-pam_dispatch2 tst-pam_dispatch3 \ tst-pam_dispatch4 tst-pam_dispatch5 \ @@ -39,7 +39,7 @@ XTESTS = tst-pam_dispatch1 tst-pam_dispatch2 tst-pam_dispatch3 \ tst-pam_group1 tst-pam_authfail tst-pam_authsucceed NOSRCTESTS = tst-pam_substack1 tst-pam_substack2 tst-pam_substack3 \ - tst-pam_substack4 tst-pam_substack5 tst-pam_assemble_line + tst-pam_substack4 tst-pam_substack5 tst-pam_assemble_line1 noinst_PROGRAMS = $(XTESTS) diff --git a/xtests/tst-pam_assemble_line.pamd b/xtests/tst-pam_assemble_line.pamd deleted file mode 100644 index 431b3ba1..00000000 --- a/xtests/tst-pam_assemble_line.pamd +++ /dev/null @@ -1,8 +0,0 @@ -#%PAM-1.0 -# Test that _pam_assemble_line() does not crash with long lines. -# printf '%511s\\\n%511s\\\n%511s\\\n%511s\\\n' - \ - \ - \ - \ -auth required pam_deny.so diff --git a/xtests/tst-pam_assemble_line.sh b/xtests/tst-pam_assemble_line.sh deleted file mode 100644 index 076b51c0..00000000 --- a/xtests/tst-pam_assemble_line.sh +++ /dev/null @@ -1,3 +0,0 @@ -#!/bin/bash - -exec ./tst-pam_authfail tst-pam_assemble_line diff --git a/xtests/tst-pam_assemble_line1.pamd b/xtests/tst-pam_assemble_line1.pamd new file mode 100644 index 00000000..431b3ba1 --- /dev/null +++ b/xtests/tst-pam_assemble_line1.pamd @@ -0,0 +1,8 @@ +#%PAM-1.0 +# Test that _pam_assemble_line() does not crash with long lines. +# printf '%511s\\\n%511s\\\n%511s\\\n%511s\\\n' + \ + \ + \ + \ +auth required pam_deny.so diff --git a/xtests/tst-pam_assemble_line1.sh b/xtests/tst-pam_assemble_line1.sh new file mode 100755 index 00000000..248d47ec --- /dev/null +++ b/xtests/tst-pam_assemble_line1.sh @@ -0,0 +1,3 @@ +#!/bin/bash + +exec ./tst-pam_authfail tst-pam_assemble_line1 -- cgit v1.2.3