diff options
Diffstat (limited to 'lib/Dist/Zilla/Plugin/OurPkgVersion.pm')
| -rw-r--r-- | lib/Dist/Zilla/Plugin/OurPkgVersion.pm | 21 |
1 files changed, 18 insertions, 3 deletions
diff --git a/lib/Dist/Zilla/Plugin/OurPkgVersion.pm b/lib/Dist/Zilla/Plugin/OurPkgVersion.pm index 0f531ac..ff2280d 100644 --- a/lib/Dist/Zilla/Plugin/OurPkgVersion.pm +++ b/lib/Dist/Zilla/Plugin/OurPkgVersion.pm @@ -3,7 +3,7 @@ use 5.014; use strict; use warnings; -our $VERSION = '0.20'; # VERSION +our $VERSION = '0.21'; # VERSION use Moose; with ( @@ -46,6 +46,12 @@ has overwrite => ( default => 0, ); +has no_critic => ( + is => 'ro', + isa => 'Bool', + default => 0, +); + sub munge_files { my $self = shift; @@ -66,7 +72,7 @@ sub BUILD { return 1; } -sub munge_file { +sub munge_file { ## no critic (Subroutines::ProhibitExcessComplexity) my ( $self, $file ) = @_; if ( $file->name =~ m/\.pod$/ixms ) { @@ -135,6 +141,8 @@ sub munge_file { if ( $version =~ /_/ && $self->underscore_eval_version ) { my $eval = "\$VERSION = eval \$VERSION;"; + $eval .= " ## no critic (BuiltinFunctions::ProhibitStringyEval)" + if $self->no_critic; $code .= $_->line? "$eval\n" : "\n$eval"; } @@ -197,7 +205,7 @@ Dist::Zilla::Plugin::OurPkgVersion - No line insertion and does Package version =head1 VERSION -version 0.20 +version 0.21 =head1 SYNOPSIS @@ -381,6 +389,13 @@ still gets modified for trial releases) Currently, the value must be a single Perl token such as a string or number. +=item no_critic + +When C<underscore_eval_version> is used the generated code for dev versions +may not technically be L<Perl::Critic> compliant due to string eval, but is +nevertheless pretty safe. This option will add the appropriate C<no critic> +directive to save you the hassle. + =back =head1 BUGS |