Don't throw a wobbly while backing up if files don't exist.

Reading extended attributes may fail with an error if the file was removed
(race condition) or in tests when generating random nonexistent directory
entries. Handle this more gracefully by not backing up the extended attributes
instead of dying completely.

1 files changed, 9 insertions, 4 deletions

diff --git a/lib/backupstore/BackupClientFileAttributes.cpp b/lib/backupstore/BackupClientFileAttributes.cpp
index d76432ba..53215b7c 100644
--- a/lib/backupstore/BackupClientFileAttributes.cpp
+++ b/lib/backupstore/BackupClientFileAttributes.cpp
@@ -664,12 +664,17 @@ void BackupClientFileAttributes::FillExtendedAttr(StreamableMemBlock &outputBloc
 					"attributes of '" << Filename << "': "
 					"buffer too small, not backed up");
 			}
+			else if(errno == ENOENT)
+			{
+				BOX_ERROR("Failed to list extended "
+					"attributes of '" << Filename << "': "
+					"file no longer exists");
+			}
 			else
 			{
-				BOX_LOG_SYS_ERROR("Failed to list extended "
-					"attributes of '" << Filename << "', "
-					"not backed up");
-				THROW_EXCEPTION(CommonException, OSFileError);
+				THROW_SYS_FILE_ERROR("Failed to list extended "
+					"attributes, skipping them", Filename,
+					CommonException, OSFileError);
 			}
 		}
 	}