diff options
authorNikolay Borisov <>2018-05-14 14:13:27 +0300
committerDavid Sterba <>2018-06-07 16:37:39 +0200
commit04be0e4b19627e9e4d7295d89c58ca08f6a04f9f (patch)
parent12087e6d75279d0e912764728d2540e8709978fe (diff)
btrfs-progs: corrupt-block: Correctly handle -r when passing -I
The documentation for the -I option (corrupt an item) states: An item to corrupt (must also specify the field to corrupt and a root+key for the item) The code on the other hand doesn't check whether -r is in fact passed, and even if it is it's not handled at all. This means presently -I is possible to corrupt items only in the root tree. Fix this by correctly checking -r is passed and fail otherwise and passing the correct root to corrupt_btrfs_item. Signed-off-by: Nikolay Borisov <> Signed-off-by: David Sterba <>
1 files changed, 7 insertions, 1 deletions
diff --git a/btrfs-corrupt-block.c b/btrfs-corrupt-block.c
index 6c587504..b2ec5dea 100644
--- a/btrfs-corrupt-block.c
+++ b/btrfs-corrupt-block.c
@@ -1337,9 +1337,15 @@ int main(int argc, char **argv)
goto out_close;
if (corrupt_item) {
+ struct btrfs_root *target;
if (!key.objectid)
- ret = corrupt_btrfs_item(root, &key, field);
+ if (!root_objectid)
+ print_usage(1);
+ target = open_root(root->fs_info, root_objectid);
+ ret = corrupt_btrfs_item(target, &key, field);
if (delete) {
struct btrfs_root *target = root;