diff options
author | Qu Wenruo <wqu@suse.com> | 2018-03-30 15:35:26 +0800 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2018-03-30 22:15:55 +0200 |
commit | 64f3dc013676544d3f6142a80cfef99644e4e49a (patch) | |
tree | 786288d9607738369f100275a42710e79a0fce5c /COPYING | |
parent | 3f42d56fcbc6420cf47bed601542a776b1bc7ca2 (diff) |
btrfs-progs: disk-io: Fix read_extent_data() error handler for missing device
When device is missing, read_extent_data() (function exported from old
btrfs check code) has the following problems:
1) Modifies @len parameter if device is missing
If device returned in @multi is missing, @len can be larger than
@max_len (originl length).
This could confuse caller and underflow in the read loop.
2) Still returns 0 for missing device
It only handles read error, missing device is not handled and 0 is
returned.
3) Wrong check for device->fd
In fact, 0 is also a valid fd.
Although not possible under most cases, but still needs fix.
Fix them all.
Fixes: 1bad2f2f2dfe ("Btrfs-progs: fsck: add an option to check data csums")
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions