Refactor and document nrepl-client.el

Refactor:

   - general code and documentation cleanup
   - use -- convention for internal function of very limited use
   - inline several very short internal functions
   - use systematic naming convention for requests. Namely nrepl-send-request and
     nrepl-send-sync-request for workhorse functions and `nrepl-request:XXX` and
     `nrepl-sync-request:OP` for requests of type "OP".
   - rename `nrepl-send-request-sync` into `nrepl-send-sync-request`
   - delete `nrepl-log-messages` command

Reorganize nrepl-client.el in functional chapters:

   - Bencode
   - Client: Process Filter
   - Client: Initialization
   - Client: Response Handling
   - Client: Request Handling
   - Server
   - Utilities
   - Connection Buffer Management
   - Connection Browser

Document the nREPL communication process.

1 files changed, 3 insertions, 7 deletions

diff --git a/cider.el b/cider.el
index f462bee0..fc8afb36 100644
--- a/cider.el
+++ b/cider.el
@@ -125,16 +125,12 @@ start the server."
           (let* ((nrepl-project-dir project-dir)
                  (cmd (format "%s %s" cider-lein-command cider-lein-parameters))
                  (default-directory (or project-dir default-directory))
-                 (nrepl-buffer-name (generate-new-buffer-name
-                                     (nrepl-server-buffer-name)))
+                 (serv-buf-name (generate-new-buffer-name (nrepl-server-buffer-name)))
                  (process
                   (progn
                     ;; the buffer has to be created before the proc:
-                    (get-buffer-create nrepl-buffer-name)
-                    (start-file-process-shell-command
-                     "nrepl-server"
-                     nrepl-buffer-name
-                     cmd))))
+                    (get-buffer-create serv-buf-name)
+                    (start-file-process-shell-command "nrepl-server" serv-buf-name cmd))))
             (set-process-filter process 'nrepl-server-filter)
             (set-process-sentinel process 'nrepl-server-sentinel)
             (set-process-coding-system process 'utf-8-unix 'utf-8-unix)