debhelper modular buildsystems (try 3).

* New feature - when listing buildsystems, list their status too
  (auto/specified).
* Dh_Buildsystem_Basic.pm renamed to Dh_Buildsystem.pm
* Addressed a few issues expressed in the comments, answered a few
  comments.
* Cache DEB_BUILD_GNU_TYPE value. Performance hit is noticable when
  listing build systems.
* is_auto_buildable() renamed to check_auto_buildable() (again).
  Since there is is_buildable() now, I didn't want to use is_ for
  that method.

Signed-off-by: Modestas Vainius <modestas@vainius.eu>

1 files changed, 6 insertions, 2 deletions

diff --git a/Debian/Debhelper/Buildsystem/autotools.pm b/Debian/Debhelper/Buildsystem/autotools.pm
index b94d8e17..74f1652e 100644
--- a/Debian/Debhelper/Buildsystem/autotools.pm
+++ b/Debian/Debhelper/Buildsystem/autotools.pm
@@ -15,9 +15,9 @@ sub DESCRIPTION {
 	"support for building GNU Autotools based packages"
 }
 
-sub is_auto_buildable {
+sub check_auto_buildable {
 	my $self=shift;
-	my $action=shift;
+	my ($action)=@_;
 
 	# Handle configure; the rest - next class
 	# XXX JEH 
@@ -30,6 +30,10 @@ sub is_auto_buildable {
 	# actions, it would use the methods inherited from its parent
 	# class. In the above example, that will try to run "make" w/o a
 	# Makefile, which prints a useful error.
+	# XXX MDX I'm all for it but this will differ from current dh_auto_build
+	#         behaviour (which is that dh_auto_build doesn't fail if
+	#         dh_auto_configure was not run). It is your call whether you are
+	#         willing to break this aspect of backwards compatibility.
 	if ($action eq "configure") {
 		return -x "configure";
 	}