summaryrefslogtreecommitdiff
path: root/compose/bundle.py
diff options
context:
space:
mode:
Diffstat (limited to 'compose/bundle.py')
-rw-r--r--compose/bundle.py11
1 files changed, 6 insertions, 5 deletions
diff --git a/compose/bundle.py b/compose/bundle.py
index afbdabfa..937a3708 100644
--- a/compose/bundle.py
+++ b/compose/bundle.py
@@ -46,8 +46,9 @@ class NeedsPush(Exception):
class NeedsPull(Exception):
- def __init__(self, image_name):
+ def __init__(self, image_name, service_name):
self.image_name = image_name
+ self.service_name = service_name
class MissingDigests(Exception):
@@ -74,7 +75,7 @@ def get_image_digests(project, allow_push=False):
except NeedsPush as e:
needs_push.add(e.image_name)
except NeedsPull as e:
- needs_pull.add(e.image_name)
+ needs_pull.add(e.service_name)
if needs_push or needs_pull:
raise MissingDigests(needs_push, needs_pull)
@@ -109,7 +110,7 @@ def get_image_digest(service, allow_push=False):
return image['RepoDigests'][0]
if 'build' not in service.options:
- raise NeedsPull(service.image_name)
+ raise NeedsPull(service.image_name, service.name)
if not allow_push:
raise NeedsPush(service.image_name)
@@ -120,7 +121,7 @@ def get_image_digest(service, allow_push=False):
def push_image(service):
try:
digest = service.push()
- except:
+ except Exception:
log.error(
"Failed to push image for service '{s.name}'. Please use an "
"image tag that can be pushed to a Docker "
@@ -201,7 +202,7 @@ def convert_service_to_bundle(name, service_dict, image_digest):
return container_config
-# See https://github.com/docker/swarmkit/blob//agent/exec/container/container.go#L95
+# See https://github.com/docker/swarmkit/blob/agent/exec/container/container.go#L95
def set_command_and_args(config, entrypoint, command):
if isinstance(entrypoint, six.string_types):
entrypoint = split_command(entrypoint)