summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2015-09-08 18:53:19 +0200
committerSven Eden <yamakuzure@gmx.net>2017-03-29 10:45:09 +0200
commit5c524c1900f85eb098ad525f80f9c61801fd9366 (patch)
tree04623fff6f37ed2da087a2f02dc3ab9690a7dc6b
parentbfe9c16671c456eb4c12e0ec01564c43a73c3127 (diff)
tree-wide: make more code use safe_close()
Replace this: close(fd); fd = -1; write this: fd = safe_close(fd);
-rw-r--r--coccinelle/safe_close.cocci18
-rw-r--r--src/login/logind-button.c6
2 files changed, 20 insertions, 4 deletions
diff --git a/coccinelle/safe_close.cocci b/coccinelle/safe_close.cocci
new file mode 100644
index 000000000..6fedd804f
--- /dev/null
+++ b/coccinelle/safe_close.cocci
@@ -0,0 +1,18 @@
+@@
+expression fd;
+@@
+- close(fd);
+- fd = -1;
++ fd = safe_close(fd);
+@@
+expression fd;
+@@
+- close_nointr(fd);
+- fd = -1;
++ fd = safe_close(fd);
+@@
+expression fd;
+@@
+- safe_close(fd);
+- fd = -1;
++ fd = safe_close(fd);
diff --git a/src/login/logind-button.c b/src/login/logind-button.c
index 210b889c4..3324c4622 100644
--- a/src/login/logind-button.c
+++ b/src/login/logind-button.c
@@ -240,8 +240,7 @@ int button_open(Button *b) {
assert(b);
if (b->fd >= 0) {
- close(b->fd);
- b->fd = -1;
+ b->fd = safe_close(b->fd);
}
p = strjoina("/dev/input/", b->name);
@@ -267,8 +266,7 @@ int button_open(Button *b) {
return 0;
fail:
- close(b->fd);
- b->fd = -1;
+ b->fd = safe_close(b->fd);
return r;
}