summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatija Skala <mskala@gmx.com>2017-04-25 14:44:29 +0200
committerSven Eden <yamakuzure@gmx.net>2017-07-25 09:46:52 +0200
commitbd7bf6b86506e336cff7cc6c391c94306049782d (patch)
tree6f9287761affe695590dfc7718a3436a0ec33c0e
parent734744fddd783fec7b19215b24c12e95c00c1e67 (diff)
fix parenthesis in pager.c (#5798)
- result of dup2 should be compared against 0 - making parenthesis around comparisons just to be sure
-rw-r--r--src/shared/pager.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/shared/pager.c b/src/shared/pager.c
index f26a9c0cb..e792381bb 100644
--- a/src/shared/pager.c
+++ b/src/shared/pager.c
@@ -176,11 +176,11 @@ void pager_close(void) {
/* Inform pager that we are done */
(void) fflush(stdout);
- if (stdout_redirected && (stored_stdout < 0 || dup2(stored_stdout, STDOUT_FILENO)) < 0)
+ if (stdout_redirected && ((stored_stdout < 0) || (dup2(stored_stdout, STDOUT_FILENO) < 0)))
(void) close(STDOUT_FILENO);
stored_stdout = safe_close(stored_stdout);
(void) fflush(stderr);
- if (stderr_redirected && (stored_stderr < 0 || dup2(stored_stderr, STDERR_FILENO)) < 0)
+ if (stderr_redirected && ((stored_stderr < 0) || (dup2(stored_stderr, STDERR_FILENO) < 0)))
(void) close(STDERR_FILENO);
stored_stderr = safe_close(stored_stderr);
stdout_redirected = stderr_redirected = false;