diff options
| author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2014-08-02 11:12:21 -0400 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2014-08-03 21:46:07 -0400 |
| commit | 601185b43da638b1c74153deae01dbd518680889 (patch) | |
| tree | b4f1bc609e57e542a03ca00553098eabbb3b196b /CODING_STYLE | |
| parent | 75cd513ef830d8e00d0d2d6a64917fec533315db (diff) | |
Unify parse_argv style
getopt is usually good at printing out a nice error message when
commandline options are invalid. It distinguishes between an unknown
option and a known option with a missing arg. It is better to let it
do its job and not use opterr=0 unless we actually want to suppress
messages. So remove opterr=0 in the few places where it wasn't really
useful.
When an error in options is encountered, we should not print a lengthy
help() and overwhelm the user, when we know precisely what is wrong
with the commandline. In addition, since help() prints to stdout, it
should not be used except when requested with -h or --help.
Also, simplify things here and there.
Diffstat (limited to 'CODING_STYLE')
| -rw-r--r-- | CODING_STYLE | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/CODING_STYLE b/CODING_STYLE index e22c1edb1..ca3b5183f 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -167,3 +167,8 @@ caching for any thread that is not the main thread. Use is_main_thread() to detect whether the calling thread is the main thread. + +- Option parsing: + - Do not print full help() on error, be specific about the error. + - Do not print messages to stdout on error. + - Do not POSIX_ME_HARDER unless necessary, i.e. avoid "+" in option string. |