summaryrefslogtreecommitdiff
path: root/src/basic/mkdir-label.c
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2018-03-27 07:38:26 +0200
committerSven Eden <yamakuzure@gmx.net>2018-08-24 16:47:08 +0200
commitd3bc5662dd8436ea2ddcd49d18a48e9a4818bb44 (patch)
treebaccb383396362a65c110d1dacb630b7e659a804 /src/basic/mkdir-label.c
parent33da2d049720dfa17bbbbf70200130fd977bfb33 (diff)
label: rework label_fix() implementations (#8583)
This reworks the SELinux and SMACK label fixing calls in a number of ways: 1. The two separate boolean arguments of these functions are converted into a flags type LabelFixFlags. 2. The operations are now implemented based on O_PATH. This should resolve TTOCTTOU races between determining the label for the file system object and applying it, as it it allows to pin the object while we are operating on it. 3. When changing a label fails we'll query the label previously set, and if matches what we want to set anyway we'll suppress the error. Also, all calls to label_fix() are now (void)ified, when we ignore the return values. Fixes: #8566
Diffstat (limited to 'src/basic/mkdir-label.c')
-rw-r--r--src/basic/mkdir-label.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/basic/mkdir-label.c b/src/basic/mkdir-label.c
index 4e5b7c961..6b4656669 100644
--- a/src/basic/mkdir-label.c
+++ b/src/basic/mkdir-label.c
@@ -44,7 +44,7 @@ int mkdir_label(const char *path, mode_t mode) {
if (r < 0)
return r;
- return mac_smack_fix(path, false, false);
+ return mac_smack_fix(path, 0);
}
int mkdir_safe_label(const char *path, mode_t mode, uid_t uid, gid_t gid, MkdirFlags flags) {