path: root/src/basic/unit-def.c
diff options
authorLennart Poettering <>2018-06-01 17:46:01 +0200
committerSven Eden <>2018-08-24 16:47:08 +0200
commitf6d804bc4caa5d0187d672a5f643e5b8cd1980ed (patch)
treec038138519abf0064c29eca9a5878d252ab46a39 /src/basic/unit-def.c
parentda6d3a3807b6f30d3ae9b76b35069f760244f5b1 (diff)
core: introduce a new load state "bad-setting"
Since bb28e68477a3a39796e4999a6cbc6ac6345a9159 parsing failures of certain unit file settings will result in load failures of units. This introduces a new load state "bad-setting" that is entered in precisely this case. With this addition error messages on bad settings should be a lot more explicit, as we don't have to show some generic "errno" error in that case, but can explicitly say that a bad setting is at fault. Internally this unit load state is entered as soon as any configuration loader call returns ENOEXEC. Hence: config parser calls should return ENOEXEC now for such essential unit file settings. Turns out, they generally already do. Fixes: #9107
Diffstat (limited to 'src/basic/unit-def.c')
1 files changed, 1 insertions, 0 deletions
diff --git a/src/basic/unit-def.c b/src/basic/unit-def.c
index 7361acb29..fd42e0a24 100644
--- a/src/basic/unit-def.c
+++ b/src/basic/unit-def.c
@@ -93,6 +93,7 @@ static const char* const unit_load_state_table[_UNIT_LOAD_STATE_MAX] = {
[UNIT_STUB] = "stub",
[UNIT_LOADED] = "loaded",
[UNIT_NOT_FOUND] = "not-found",
+ [UNIT_BAD_SETTING] = "bad-setting",
[UNIT_ERROR] = "error",
[UNIT_MERGED] = "merged",
[UNIT_MASKED] = "masked"