summaryrefslogtreecommitdiff
path: root/src/basic/xattr-util.h
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2015-11-28 18:41:08 -0500
committerSven Eden <yamakuzure@gmx.net>2017-05-17 15:22:14 +0200
commit7fd82b1492ab3a8987095b237dc8c4b7ab6d00de (patch)
tree91a92a911d4945514a78b53d3e26d5815ce86cbe /src/basic/xattr-util.h
parent754a768833613e94527ef4403e62858bce189db4 (diff)
acl-util: only set the mask if not present
When we have non-owner user or group entries, we need the mask for the acl to be valid. But acl_calc_mask() calculates the mask to include all permissions, even those that were masked before. Apparently this happens when we inherit *:r-x permissions from a parent directory — the kernel sets *:r-x, mask:r--, effectively masking the executable bit. acl_calc_mask() would set the mask:r-x, effectively enabling the bit. To avoid this, be more conservative when to add the mask entry: first iterate over all entries, and do nothing if a mask. This returns the code closer to J.A.Steffens' original version in v204-90-g23ad4dd884. Should fix https://github.com/elogind/elogind/issues/1977.
Diffstat (limited to 'src/basic/xattr-util.h')
0 files changed, 0 insertions, 0 deletions