treewide: use log_*_errno whenever %m is in the format string

If the format string contains %m, clearly errno must have a meaningful
value, so we might as well use log_*_errno to have ERRNO= logged.

Using:
find . -name '*.[ch]' | xargs sed -r -i -e \
's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/'

Plus some whitespace, linewrap, and indent adjustments.

1 files changed, 7 insertions, 7 deletions

diff --git a/src/shared/capability.c b/src/shared/capability.c
index b7e055318..e2e0dd1a3 100644
--- a/src/shared/capability.c
+++ b/src/shared/capability.c
@@ -228,28 +228,28 @@ int drop_privileges(uid_t uid, gid_t gid, uint64_t keep_capabilities) {
          * which we want to avoid. */
 
         if (setresgid(gid, gid, gid) < 0) {
-                log_error("Failed to change group ID: %m");
+                log_error_errno(errno, "Failed to change group ID: %m");
                 return -errno;
         }
 
         if (setgroups(0, NULL) < 0) {
-                log_error("Failed to drop auxiliary groups list: %m");
+                log_error_errno(errno, "Failed to drop auxiliary groups list: %m");
                 return -errno;
         }
 
         if (prctl(PR_SET_KEEPCAPS, 1) < 0) {
-                log_error("Failed to enable keep capabilities flag: %m");
+                log_error_errno(errno, "Failed to enable keep capabilities flag: %m");
                 return -errno;
         }
 
         r = setresuid(uid, uid, uid);
         if (r < 0) {
-                log_error("Failed to change user ID: %m");
+                log_error_errno(errno, "Failed to change user ID: %m");
                 return -errno;
         }
 
         if (prctl(PR_SET_KEEPCAPS, 0) < 0) {
-                log_error("Failed to disable keep capabilities flag: %m");
+                log_error_errno(errno, "Failed to disable keep capabilities flag: %m");
                 return -errno;
         }
 
@@ -271,13 +271,13 @@ int drop_privileges(uid_t uid, gid_t gid, uint64_t keep_capabilities) {
 
                 if (cap_set_flag(d, CAP_EFFECTIVE, j, bits, CAP_SET) < 0 ||
                     cap_set_flag(d, CAP_PERMITTED, j, bits, CAP_SET) < 0) {
-                        log_error("Failed to enable capabilities bits: %m");
+                        log_error_errno(errno, "Failed to enable capabilities bits: %m");
                         return -errno;
                 }
         }
 
         if (cap_set_proc(d) < 0) {
-                log_error("Failed to increase capabilities: %m");
+                log_error_errno(errno, "Failed to increase capabilities: %m");
                 return -errno;
         }