summaryrefslogtreecommitdiff
path: root/tests/rest/client/v1/test_rooms.py
blob: 9fe0760496de06fdd91cb4e5a172bd5a8ebe1b14 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
# -*- coding: utf-8 -*-
# Copyright 2014-2016 OpenMarket Ltd
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Tests REST events for /rooms paths."""

import json

from mock import Mock, NonCallableMock
from six.moves.urllib import parse as urlparse

from twisted.internet import defer

import synapse.rest.client.v1.room
from synapse.api.constants import Membership
from synapse.http.server import JsonResource
from synapse.types import UserID
from synapse.util import Clock

from tests import unittest
from tests.server import (
    ThreadedMemoryReactorClock,
    make_request,
    render,
    setup_test_homeserver,
)

from .utils import RestHelper

PATH_PREFIX = b"/_matrix/client/api/v1"


class RoomBase(unittest.TestCase):
    rmcreator_id = None

    def setUp(self):

        self.clock = ThreadedMemoryReactorClock()
        self.hs_clock = Clock(self.clock)

        self.hs = setup_test_homeserver(
            self.addCleanup,
            "red",
            http_client=None,
            clock=self.hs_clock,
            reactor=self.clock,
            federation_client=Mock(),
            ratelimiter=NonCallableMock(spec_set=["send_message"]),
        )
        self.ratelimiter = self.hs.get_ratelimiter()
        self.ratelimiter.send_message.return_value = (True, 0)

        self.hs.get_federation_handler = Mock(return_value=Mock())

        def get_user_by_access_token(token=None, allow_guest=False):
            return {
                "user": UserID.from_string(self.helper.auth_user_id),
                "token_id": 1,
                "is_guest": False,
            }

        def get_user_by_req(request, allow_guest=False, rights="access"):
            return synapse.types.create_requester(
                UserID.from_string(self.helper.auth_user_id), 1, False, None
            )

        self.hs.get_auth().get_user_by_req = get_user_by_req
        self.hs.get_auth().get_user_by_access_token = get_user_by_access_token
        self.hs.get_auth().get_access_token_from_request = Mock(return_value=b"1234")

        def _insert_client_ip(*args, **kwargs):
            return defer.succeed(None)

        self.hs.get_datastore().insert_client_ip = _insert_client_ip

        self.resource = JsonResource(self.hs)
        synapse.rest.client.v1.room.register_servlets(self.hs, self.resource)
        synapse.rest.client.v1.room.register_deprecated_servlets(self.hs, self.resource)
        self.helper = RestHelper(self.hs, self.resource, self.user_id)


class RoomPermissionsTestCase(RoomBase):
    """ Tests room permissions. """

    user_id = b"@sid1:red"
    rmcreator_id = b"@notme:red"

    def setUp(self):

        super(RoomPermissionsTestCase, self).setUp()

        self.helper.auth_user_id = self.rmcreator_id
        # create some rooms under the name rmcreator_id
        self.uncreated_rmid = "!aa:test"
        self.created_rmid = self.helper.create_room_as(
            self.rmcreator_id, is_public=False
        )
        self.created_public_rmid = self.helper.create_room_as(
            self.rmcreator_id, is_public=True
        )

        # send a message in one of the rooms
        self.created_rmid_msg_path = (
            "rooms/%s/send/m.room.message/a1" % (self.created_rmid)
        ).encode('ascii')
        request, channel = make_request(
            b"PUT",
            self.created_rmid_msg_path,
            b'{"msgtype":"m.text","body":"test msg"}',
        )
        render(request, self.resource, self.clock)
        self.assertEquals(channel.result["code"], b"200", channel.result)

        # set topic for public room
        request, channel = make_request(
            b"PUT",
            ("rooms/%s/state/m.room.topic" % self.created_public_rmid).encode('ascii'),
            b'{"topic":"Public Room Topic"}',
        )
        render(request, self.resource, self.clock)
        self.assertEquals(channel.result["code"], b"200", channel.result)

        # auth as user_id now
        self.helper.auth_user_id = self.user_id

    def test_send_message(self):
        msg_content = b'{"msgtype":"m.text","body":"hello"}'

        seq = iter(range(100))

        def send_msg_path():
            return b"/rooms/%s/send/m.room.message/mid%s" % (
                self.created_rmid,
                str(next(seq)).encode('ascii'),
            )

        # send message in uncreated room, expect 403
        request, channel = make_request(
            b"PUT",
            b"/rooms/%s/send/m.room.message/mid2" % (self.uncreated_rmid,),
            msg_content,
        )
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        # send message in created room not joined (no state), expect 403
        request, channel = make_request(b"PUT", send_msg_path(), msg_content)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        # send message in created room and invited, expect 403
        self.helper.invite(
            room=self.created_rmid, src=self.rmcreator_id, targ=self.user_id
        )
        request, channel = make_request(b"PUT", send_msg_path(), msg_content)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        # send message in created room and joined, expect 200
        self.helper.join(room=self.created_rmid, user=self.user_id)
        request, channel = make_request(b"PUT", send_msg_path(), msg_content)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        # send message in created room and left, expect 403
        self.helper.leave(room=self.created_rmid, user=self.user_id)
        request, channel = make_request(b"PUT", send_msg_path(), msg_content)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

    def test_topic_perms(self):
        topic_content = b'{"topic":"My Topic Name"}'
        topic_path = b"/rooms/%s/state/m.room.topic" % self.created_rmid

        # set/get topic in uncreated room, expect 403
        request, channel = make_request(
            b"PUT", b"/rooms/%s/state/m.room.topic" % self.uncreated_rmid, topic_content
        )
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])
        request, channel = make_request(
            b"GET", "/rooms/%s/state/m.room.topic" % self.uncreated_rmid
        )
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        # set/get topic in created PRIVATE room not joined, expect 403
        request, channel = make_request(b"PUT", topic_path, topic_content)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])
        request, channel = make_request(b"GET", topic_path)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        # set topic in created PRIVATE room and invited, expect 403
        self.helper.invite(
            room=self.created_rmid, src=self.rmcreator_id, targ=self.user_id
        )
        request, channel = make_request(b"PUT", topic_path, topic_content)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        # get topic in created PRIVATE room and invited, expect 403
        request, channel = make_request(b"GET", topic_path)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        # set/get topic in created PRIVATE room and joined, expect 200
        self.helper.join(room=self.created_rmid, user=self.user_id)

        # Only room ops can set topic by default
        self.helper.auth_user_id = self.rmcreator_id
        request, channel = make_request(b"PUT", topic_path, topic_content)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])
        self.helper.auth_user_id = self.user_id

        request, channel = make_request(b"GET", topic_path)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])
        self.assert_dict(json.loads(topic_content), channel.json_body)

        # set/get topic in created PRIVATE room and left, expect 403
        self.helper.leave(room=self.created_rmid, user=self.user_id)
        request, channel = make_request(b"PUT", topic_path, topic_content)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])
        request, channel = make_request(b"GET", topic_path)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        # get topic in PUBLIC room, not joined, expect 403
        request, channel = make_request(
            b"GET", b"/rooms/%s/state/m.room.topic" % self.created_public_rmid
        )
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        # set topic in PUBLIC room, not joined, expect 403
        request, channel = make_request(
            b"PUT",
            b"/rooms/%s/state/m.room.topic" % self.created_public_rmid,
            topic_content,
        )
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

    def _test_get_membership(self, room=None, members=[], expect_code=None):
        for member in members:
            path = b"/rooms/%s/state/m.room.member/%s" % (room, member)
            request, channel = make_request(b"GET", path)
            render(request, self.resource, self.clock)
            self.assertEquals(expect_code, int(channel.result["code"]))

    def test_membership_basic_room_perms(self):
        # === room does not exist ===
        room = self.uncreated_rmid
        # get membership of self, get membership of other, uncreated room
        # expect all 403s
        self._test_get_membership(
            members=[self.user_id, self.rmcreator_id], room=room, expect_code=403
        )

        # trying to invite people to this room should 403
        self.helper.invite(
            room=room, src=self.user_id, targ=self.rmcreator_id, expect_code=403
        )

        # set [invite/join/left] of self, set [invite/join/left] of other,
        # expect all 404s because room doesn't exist on any server
        for usr in [self.user_id, self.rmcreator_id]:
            self.helper.join(room=room, user=usr, expect_code=404)
            self.helper.leave(room=room, user=usr, expect_code=404)

    def test_membership_private_room_perms(self):
        room = self.created_rmid
        # get membership of self, get membership of other, private room + invite
        # expect all 403s
        self.helper.invite(room=room, src=self.rmcreator_id, targ=self.user_id)
        self._test_get_membership(
            members=[self.user_id, self.rmcreator_id], room=room, expect_code=403
        )

        # get membership of self, get membership of other, private room + joined
        # expect all 200s
        self.helper.join(room=room, user=self.user_id)
        self._test_get_membership(
            members=[self.user_id, self.rmcreator_id], room=room, expect_code=200
        )

        # get membership of self, get membership of other, private room + left
        # expect all 200s
        self.helper.leave(room=room, user=self.user_id)
        self._test_get_membership(
            members=[self.user_id, self.rmcreator_id], room=room, expect_code=200
        )

    def test_membership_public_room_perms(self):
        room = self.created_public_rmid
        # get membership of self, get membership of other, public room + invite
        # expect 403
        self.helper.invite(room=room, src=self.rmcreator_id, targ=self.user_id)
        self._test_get_membership(
            members=[self.user_id, self.rmcreator_id], room=room, expect_code=403
        )

        # get membership of self, get membership of other, public room + joined
        # expect all 200s
        self.helper.join(room=room, user=self.user_id)
        self._test_get_membership(
            members=[self.user_id, self.rmcreator_id], room=room, expect_code=200
        )

        # get membership of self, get membership of other, public room + left
        # expect 200.
        self.helper.leave(room=room, user=self.user_id)
        self._test_get_membership(
            members=[self.user_id, self.rmcreator_id], room=room, expect_code=200
        )

    def test_invited_permissions(self):
        room = self.created_rmid
        self.helper.invite(room=room, src=self.rmcreator_id, targ=self.user_id)

        # set [invite/join/left] of other user, expect 403s
        self.helper.invite(
            room=room, src=self.user_id, targ=self.rmcreator_id, expect_code=403
        )
        self.helper.change_membership(
            room=room,
            src=self.user_id,
            targ=self.rmcreator_id,
            membership=Membership.JOIN,
            expect_code=403,
        )
        self.helper.change_membership(
            room=room,
            src=self.user_id,
            targ=self.rmcreator_id,
            membership=Membership.LEAVE,
            expect_code=403,
        )

    def test_joined_permissions(self):
        room = self.created_rmid
        self.helper.invite(room=room, src=self.rmcreator_id, targ=self.user_id)
        self.helper.join(room=room, user=self.user_id)

        # set invited of self, expect 403
        self.helper.invite(
            room=room, src=self.user_id, targ=self.user_id, expect_code=403
        )

        # set joined of self, expect 200 (NOOP)
        self.helper.join(room=room, user=self.user_id)

        other = "@burgundy:red"
        # set invited of other, expect 200
        self.helper.invite(room=room, src=self.user_id, targ=other, expect_code=200)

        # set joined of other, expect 403
        self.helper.change_membership(
            room=room,
            src=self.user_id,
            targ=other,
            membership=Membership.JOIN,
            expect_code=403,
        )

        # set left of other, expect 403
        self.helper.change_membership(
            room=room,
            src=self.user_id,
            targ=other,
            membership=Membership.LEAVE,
            expect_code=403,
        )

        # set left of self, expect 200
        self.helper.leave(room=room, user=self.user_id)

    def test_leave_permissions(self):
        room = self.created_rmid
        self.helper.invite(room=room, src=self.rmcreator_id, targ=self.user_id)
        self.helper.join(room=room, user=self.user_id)
        self.helper.leave(room=room, user=self.user_id)

        # set [invite/join/left] of self, set [invite/join/left] of other,
        # expect all 403s
        for usr in [self.user_id, self.rmcreator_id]:
            self.helper.change_membership(
                room=room,
                src=self.user_id,
                targ=usr,
                membership=Membership.INVITE,
                expect_code=403,
            )

            self.helper.change_membership(
                room=room,
                src=self.user_id,
                targ=usr,
                membership=Membership.JOIN,
                expect_code=403,
            )

        # It is always valid to LEAVE if you've already left (currently.)
        self.helper.change_membership(
            room=room,
            src=self.user_id,
            targ=self.rmcreator_id,
            membership=Membership.LEAVE,
            expect_code=403,
        )


class RoomsMemberListTestCase(RoomBase):
    """ Tests /rooms/$room_id/members/list REST events."""

    user_id = b"@sid1:red"

    def test_get_member_list(self):
        room_id = self.helper.create_room_as(self.user_id)
        request, channel = make_request(b"GET", b"/rooms/%s/members" % room_id)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

    def test_get_member_list_no_room(self):
        request, channel = make_request(b"GET", b"/rooms/roomdoesnotexist/members")
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

    def test_get_member_list_no_permission(self):
        room_id = self.helper.create_room_as(b"@some_other_guy:red")
        request, channel = make_request(b"GET", b"/rooms/%s/members" % room_id)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

    def test_get_member_list_mixed_memberships(self):
        room_creator = b"@some_other_guy:red"
        room_id = self.helper.create_room_as(room_creator)
        room_path = b"/rooms/%s/members" % room_id
        self.helper.invite(room=room_id, src=room_creator, targ=self.user_id)
        # can't see list if you're just invited.
        request, channel = make_request(b"GET", room_path)
        render(request, self.resource, self.clock)
        self.assertEquals(403, int(channel.result["code"]), msg=channel.result["body"])

        self.helper.join(room=room_id, user=self.user_id)
        # can see list now joined
        request, channel = make_request(b"GET", room_path)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        self.helper.leave(room=room_id, user=self.user_id)
        # can see old list once left
        request, channel = make_request(b"GET", room_path)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])


class RoomsCreateTestCase(RoomBase):
    """ Tests /rooms and /rooms/$room_id REST events. """

    user_id = b"@sid1:red"

    def test_post_room_no_keys(self):
        # POST with no config keys, expect new room id
        request, channel = make_request(b"POST", b"/createRoom", b"{}")

        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), channel.result)
        self.assertTrue("room_id" in channel.json_body)

    def test_post_room_visibility_key(self):
        # POST with visibility config key, expect new room id
        request, channel = make_request(
            b"POST", b"/createRoom", b'{"visibility":"private"}'
        )
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]))
        self.assertTrue("room_id" in channel.json_body)

    def test_post_room_custom_key(self):
        # POST with custom config keys, expect new room id
        request, channel = make_request(b"POST", b"/createRoom", b'{"custom":"stuff"}')
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]))
        self.assertTrue("room_id" in channel.json_body)

    def test_post_room_known_and_unknown_keys(self):
        # POST with custom + known config keys, expect new room id
        request, channel = make_request(
            b"POST", b"/createRoom", b'{"visibility":"private","custom":"things"}'
        )
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]))
        self.assertTrue("room_id" in channel.json_body)

    def test_post_room_invalid_content(self):
        # POST with invalid content / paths, expect 400
        request, channel = make_request(b"POST", b"/createRoom", b'{"visibili')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]))

        request, channel = make_request(b"POST", b"/createRoom", b'["hello"]')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]))


class RoomTopicTestCase(RoomBase):
    """ Tests /rooms/$room_id/topic REST events. """

    user_id = b"@sid1:red"

    def setUp(self):

        super(RoomTopicTestCase, self).setUp()

        # create the room
        self.room_id = self.helper.create_room_as(self.user_id)
        self.path = b"/rooms/%s/state/m.room.topic" % (self.room_id,)

    def test_invalid_puts(self):
        # missing keys or invalid json
        request, channel = make_request(b"PUT", self.path, '{}')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", self.path, '{"_name":"bob"}')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", self.path, '{"nao')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(
            b"PUT", self.path, '[{"_name":"bob"},{"_name":"jill"}]'
        )
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", self.path, 'text only')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", self.path, '')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        # valid key, wrong type
        content = '{"topic":["Topic name"]}'
        request, channel = make_request(b"PUT", self.path, content)
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

    def test_rooms_topic(self):
        # nothing should be there
        request, channel = make_request(b"GET", self.path)
        render(request, self.resource, self.clock)
        self.assertEquals(404, int(channel.result["code"]), msg=channel.result["body"])

        # valid put
        content = '{"topic":"Topic name"}'
        request, channel = make_request(b"PUT", self.path, content)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        # valid get
        request, channel = make_request(b"GET", self.path)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])
        self.assert_dict(json.loads(content), channel.json_body)

    def test_rooms_topic_with_extra_keys(self):
        # valid put with extra keys
        content = '{"topic":"Seasons","subtopic":"Summer"}'
        request, channel = make_request(b"PUT", self.path, content)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        # valid get
        request, channel = make_request(b"GET", self.path)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])
        self.assert_dict(json.loads(content), channel.json_body)


class RoomMemberStateTestCase(RoomBase):
    """ Tests /rooms/$room_id/members/$user_id/state REST events. """

    user_id = b"@sid1:red"

    def setUp(self):

        super(RoomMemberStateTestCase, self).setUp()
        self.room_id = self.helper.create_room_as(self.user_id)

    def tearDown(self):
        pass

    def test_invalid_puts(self):
        path = "/rooms/%s/state/m.room.member/%s" % (self.room_id, self.user_id)
        # missing keys or invalid json
        request, channel = make_request(b"PUT", path, '{}')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", path, '{"_name":"bob"}')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", path, '{"nao')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(
            b"PUT", path, b'[{"_name":"bob"},{"_name":"jill"}]'
        )
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", path, 'text only')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", path, '')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        # valid keys, wrong types
        content = '{"membership":["%s","%s","%s"]}' % (
            Membership.INVITE,
            Membership.JOIN,
            Membership.LEAVE,
        )
        request, channel = make_request(b"PUT", path, content.encode('ascii'))
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

    def test_rooms_members_self(self):
        path = "/rooms/%s/state/m.room.member/%s" % (
            urlparse.quote(self.room_id),
            self.user_id,
        )

        # valid join message (NOOP since we made the room)
        content = '{"membership":"%s"}' % Membership.JOIN
        request, channel = make_request(b"PUT", path, content.encode('ascii'))
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"GET", path, None)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        expected_response = {"membership": Membership.JOIN}
        self.assertEquals(expected_response, channel.json_body)

    def test_rooms_members_other(self):
        self.other_id = "@zzsid1:red"
        path = "/rooms/%s/state/m.room.member/%s" % (
            urlparse.quote(self.room_id),
            self.other_id,
        )

        # valid invite message
        content = '{"membership":"%s"}' % Membership.INVITE
        request, channel = make_request(b"PUT", path, content)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"GET", path, None)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])
        self.assertEquals(json.loads(content), channel.json_body)

    def test_rooms_members_other_custom_keys(self):
        self.other_id = "@zzsid1:red"
        path = "/rooms/%s/state/m.room.member/%s" % (
            urlparse.quote(self.room_id),
            self.other_id,
        )

        # valid invite message with custom key
        content = '{"membership":"%s","invite_text":"%s"}' % (
            Membership.INVITE,
            "Join us!",
        )
        request, channel = make_request(b"PUT", path, content)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"GET", path, None)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])
        self.assertEquals(json.loads(content), channel.json_body)


class RoomMessagesTestCase(RoomBase):
    """ Tests /rooms/$room_id/messages/$user_id/$msg_id REST events. """

    user_id = "@sid1:red"

    def setUp(self):
        super(RoomMessagesTestCase, self).setUp()

        self.room_id = self.helper.create_room_as(self.user_id)

    def test_invalid_puts(self):
        path = "/rooms/%s/send/m.room.message/mid1" % (urlparse.quote(self.room_id))
        # missing keys or invalid json
        request, channel = make_request(b"PUT", path, '{}')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", path, '{"_name":"bob"}')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", path, '{"nao')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(
            b"PUT", path, '[{"_name":"bob"},{"_name":"jill"}]'
        )
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", path, 'text only')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        request, channel = make_request(b"PUT", path, '')
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

    def test_rooms_messages_sent(self):
        path = "/rooms/%s/send/m.room.message/mid1" % (urlparse.quote(self.room_id))

        content = '{"body":"test","msgtype":{"type":"a"}}'
        request, channel = make_request(b"PUT", path, content)
        render(request, self.resource, self.clock)
        self.assertEquals(400, int(channel.result["code"]), msg=channel.result["body"])

        # custom message types
        content = '{"body":"test","msgtype":"test.custom.text"}'
        request, channel = make_request(b"PUT", path, content)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])

        # m.text message type
        path = "/rooms/%s/send/m.room.message/mid2" % (urlparse.quote(self.room_id))
        content = '{"body":"test2","msgtype":"m.text"}'
        request, channel = make_request(b"PUT", path, content)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]), msg=channel.result["body"])


class RoomInitialSyncTestCase(RoomBase):
    """ Tests /rooms/$room_id/initialSync. """

    user_id = "@sid1:red"

    def setUp(self):
        super(RoomInitialSyncTestCase, self).setUp()

        # create the room
        self.room_id = self.helper.create_room_as(self.user_id)

    def test_initial_sync(self):
        request, channel = make_request(b"GET", "/rooms/%s/initialSync" % self.room_id)
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]))

        self.assertEquals(self.room_id, channel.json_body["room_id"])
        self.assertEquals("join", channel.json_body["membership"])

        # Room state is easier to assert on if we unpack it into a dict
        state = {}
        for event in channel.json_body["state"]:
            if "state_key" not in event:
                continue
            t = event["type"]
            if t not in state:
                state[t] = []
            state[t].append(event)

        self.assertTrue("m.room.create" in state)

        self.assertTrue("messages" in channel.json_body)
        self.assertTrue("chunk" in channel.json_body["messages"])
        self.assertTrue("end" in channel.json_body["messages"])

        self.assertTrue("presence" in channel.json_body)

        presence_by_user = {
            e["content"]["user_id"]: e for e in channel.json_body["presence"]
        }
        self.assertTrue(self.user_id in presence_by_user)
        self.assertEquals("m.presence", presence_by_user[self.user_id]["type"])


class RoomMessageListTestCase(RoomBase):
    """ Tests /rooms/$room_id/messages REST events. """

    user_id = "@sid1:red"

    def setUp(self):
        super(RoomMessageListTestCase, self).setUp()
        self.room_id = self.helper.create_room_as(self.user_id)

    def test_topo_token_is_accepted(self):
        token = "t1-0_0_0_0_0_0_0_0_0"
        request, channel = make_request(
            b"GET", "/rooms/%s/messages?access_token=x&from=%s" % (self.room_id, token)
        )
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]))
        self.assertTrue("start" in channel.json_body)
        self.assertEquals(token, channel.json_body['start'])
        self.assertTrue("chunk" in channel.json_body)
        self.assertTrue("end" in channel.json_body)

    def test_stream_token_is_accepted_for_fwd_pagianation(self):
        token = "s0_0_0_0_0_0_0_0_0"
        request, channel = make_request(
            b"GET", "/rooms/%s/messages?access_token=x&from=%s" % (self.room_id, token)
        )
        render(request, self.resource, self.clock)
        self.assertEquals(200, int(channel.result["code"]))
        self.assertTrue("start" in channel.json_body)
        self.assertEquals(token, channel.json_body['start'])
        self.assertTrue("chunk" in channel.json_body)
        self.assertTrue("end" in channel.json_body)