summaryrefslogtreecommitdiff
path: root/ssh-sk-client.c
diff options
context:
space:
mode:
authordjm@openbsd.org <djm@openbsd.org>2022-01-14 03:34:00 +0000
committerDamien Miller <djm@mindrot.org>2022-01-14 14:40:40 +1100
commit014e2f147a2788bfb3cc58d1b170dcf2bf2ee493 (patch)
tree8017e42ee1888c71870b59fe670824fd688664d3 /ssh-sk-client.c
parentc88265f207dfe0e8bdbaf9f0eda63ed6b33781cf (diff)
upstream: sshsk_load_resident: don't preallocate resp
resp is allocated by client_converse(), at which point we lose the original pointer. From Pedro Martelletto; ok dtucker & me OpenBSD-Commit-ID: 1f1b5ea3282017d6584dfed4f8370dc1db1f44b1
Diffstat (limited to 'ssh-sk-client.c')
-rw-r--r--ssh-sk-client.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/ssh-sk-client.c b/ssh-sk-client.c
index 7b5752a6e..321fe53a2 100644
--- a/ssh-sk-client.c
+++ b/ssh-sk-client.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-sk-client.c,v 1.11 2022/01/14 03:32:52 djm Exp $ */
+/* $OpenBSD: ssh-sk-client.c,v 1.12 2022/01/14 03:34:00 djm Exp $ */
/*
* Copyright (c) 2019 Google LLC
*
@@ -407,8 +407,7 @@ sshsk_load_resident(const char *provider_path, const char *device,
*srksp = NULL;
*nsrksp = 0;
- if ((resp = sshbuf_new()) == NULL ||
- (kbuf = sshbuf_new()) == NULL ||
+ if ((kbuf = sshbuf_new()) == NULL ||
(req = sshbuf_new()) == NULL) {
r = SSH_ERR_ALLOC_FAIL;
goto out;